Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1296363003: Remove stale function declaration in BrowserPluginGuest. (Closed)

Created:
5 years, 4 months ago by wjmaclean
Modified:
5 years, 4 months ago
Reviewers:
paulmeyer
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove stale function declaration in BrowserPluginGuest. The declaration of InAutoSizeBounds is stale since (i) it's not called anywhere, and (ii) it has no definition. Presumably it's leftover from whatever CL removed the function and it's caller. BUG=none Committed: https://crrev.com/472d6805e25ffc20625dfaea36ea8a1794d9a24e Cr-Commit-Position: refs/heads/master@{#344230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/browser/browser_plugin/browser_plugin_guest.h View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296363003/1
5 years, 4 months ago (2015-08-18 18:27:50 UTC) #2
wjmaclean
One-liner, cleanup - please take a look?
5 years, 4 months ago (2015-08-18 18:28:24 UTC) #4
paulmeyer
On 2015/08/18 18:28:24, wjmaclean wrote: > One-liner, cleanup - please take a look? LGTM
5 years, 4 months ago (2015-08-18 18:34:16 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-18 21:24:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1296363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1296363003/1
5 years, 4 months ago (2015-08-19 15:22:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 15:27:44 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 15:28:41 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/472d6805e25ffc20625dfaea36ea8a1794d9a24e
Cr-Commit-Position: refs/heads/master@{#344230}

Powered by Google App Engine
This is Rietveld 408576698