blimp/common/BUILD.gn - Issue 1295243003: Initial commit of the blimp/ folder and target

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: blimp/common/BUILD.gn

Issue 1295243003: Initial commit of the blimp/ folder and target (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 component("blimp_common") {

	6 sources = [

	7 # TODO(dtrainor): Remove this once the LayerTreeHost settings for Blimp

	8 # are finalized or are pushed from the server component.
	Wez 2015/09/03 00:49:28 nit: Do we have a bug filed to track that work, th nit: Do we have a bug filed to track that work, that you can refer to here? David Trainor- moved to gerrit 2015/09/03 06:33:22 We don't, but I'll file one. Show quoted text On 2015/09/03 00:49:28, Wez wrote: > nit: Do we have a bug filed to track that work, that you can refer to here? We don't, but I'll file one. Wez 2015/09/03 18:26:10 Thanks. :) Show quoted text On 2015/09/03 06:33:22, David Trainor (OOO) wrote: > On 2015/09/03 00:49:28, Wez wrote: > > nit: Do we have a bug filed to track that work, that you can refer to here? > > We don't, but I'll file one. Thanks. :)
	9 "../../content/public/common/content_switches.cc",

	10 "blimp_common_export.h",

	11 "compositor/blimp_layer_tree_settings.cc",

	12 "compositor/blimp_layer_tree_settings.h",

	13 ]

	14

	15 defines = [ "BLIMP_COMMON_IMPLEMENTATION=1" ]

	16

	17 deps = [

	18 "//base",

	19 "//cc",

	20 "//skia",

	21 "//ui/gfx/geometry",

	22 "//ui/gl",

	23 ]

	24 }

OLD	NEW