Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: chrome/browser/bookmarks/bookmark_model.h

Issue 12952005: Delay bookmarks load while the profile is loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add ObjectDestructionOrder unit test. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_model.h
diff --git a/chrome/browser/bookmarks/bookmark_model.h b/chrome/browser/bookmarks/bookmark_model.h
index 0ffab9788cd23f110cc26e00853acdbc7270f12b..a8d3021c19d792bd76bbccdbbaf47b8d2877791d 100644
--- a/chrome/browser/bookmarks/bookmark_model.h
+++ b/chrome/browser/bookmarks/bookmark_model.h
@@ -13,6 +13,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/observer_list.h"
+#include "base/sequenced_task_runner.h"
erikwright (departed) 2013/04/15 17:56:25 forward-decl ought to do it here?
msarda 2013/04/17 09:53:55 Done.
#include "base/string16.h"
#include "base/synchronization/lock.h"
#include "base/synchronization/waitable_event.h"
@@ -236,7 +237,7 @@ class BookmarkModel : public content::NotificationObserver,
// Loads the bookmarks. This is called upon creation of the
// BookmarkModel. You need not invoke this directly.
- void Load();
+ void Load(const scoped_refptr<base::SequencedTaskRunner>& task_runner);
erikwright (departed) 2013/04/15 17:56:25 need some documentation for this parameter
msarda 2013/04/17 09:53:55 Done.
// Returns true if the model finished loading.
// This is virtual so it can be mocked.

Powered by Google App Engine
This is Rietveld 408576698