Delay bookmarks load while the profile is loading.

chrome/browser/bookmarks/bookmark_model.cc

Index: chrome/browser/bookmarks/bookmark_model.cc
diff --git a/chrome/browser/bookmarks/bookmark_model.cc b/chrome/browser/bookmarks/bookmark_model.cc
index 52533b4c2be72210353f7fc5c17cb7d33441eae5..0e392c8550775dceea184f82d98804841b1f5990 100644
--- a/chrome/browser/bookmarks/bookmark_model.cc
+++ b/chrome/browser/bookmarks/bookmark_model.cc
@@ -233,7 +233,7 @@ void BookmarkModel::Shutdown() {
   loaded_signal_.Signal();
 }
 
-void BookmarkModel::Load() {
+void BookmarkModel::Load(scoped_refptr<base::SequencedTaskRunner> task_runner) {

[Miranda Callahan, 2013/03/29 14:40:13]

Do we really need to pass the task_runner here? Now that the task_runner is a
PKS, we can just get it directly anywhere we know what the Profile is. Since you
already have the Profile information here, you can skip passing in the
task_runner, and just pass

StartupTaskRunnerServiceFactory::GetForProfile(profile)->GetBookmarkTaskRunner()

below.

[msarda, 2013/03/29 14:46:24]

I did that in a local change. However, I understood from the other files that we
want the bookmarks to be a component and have less dependency on
chrome/browser/.. code. I used this approach for that reason and for unit tests.

@sky: Let me know what is the approach you guys prefer here and I'll do the
change accordingly.

On 2013/03/29 14:40:13, Miranda Callahan wrote:

   if (store_.get()) {
     // If the store is non-null, it means Load was already invoked. Load should
     // only be invoked once.
@@ -250,7 +250,7 @@ void BookmarkModel::Load() {
                  content::Source<Profile>(profile_));
 
   // Load the bookmarks. BookmarkStorage notifies us when done.
-  store_ = new BookmarkStorage(profile_, this, profile_->GetIOTaskRunner());
+  store_ = new BookmarkStorage(profile_, this, task_runner);

[Miranda Callahan, 2013/03/29 14:40:13]

see comment on "Load" above.

   store_->LoadBookmarks(CreateLoadDetails());
 }