chrome/test/base/ui_test_utils.cc - Issue 12952005: Delay bookmarks load while the profile is loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/ui_test_utils.cc

Issue 12952005: Delay bookmarks load while the profile is loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address mirandac's comments: add BookmarkModel::StartLoading Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/base/ui_test_utils.cc

diff --git a/chrome/test/base/ui_test_utils.cc b/chrome/test/base/ui_test_utils.cc

index ccd9bdd64aad171a1c8163ff708f158e64e8c7ce..3c7b7f5eb96fce23726680b56a08b03a08f877b5 100644

--- a/chrome/test/base/ui_test_utils.cc

+++ b/chrome/test/base/ui_test_utils.cc

@@ -418,6 +418,7 @@ void RegisterAndWait(content::NotificationObserver* observer,

void WaitForBookmarkModelToLoad(BookmarkModel* model) {

if (model->IsLoaded())

return;

+ model->StartLoading();

base::RunLoop run_loop;

BookmarkLoadObserver observer(content::GetQuitTaskForRunLoop(&run_loop));

model->AddObserver(&observer);