Issue 12947005: chromeos: Fix missing FontConfig calls in default-font code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12947005: chromeos: Fix missing FontConfig calls in default-font code. (Closed)

Created:
7 years, 9 months ago by Daniel Erat

Modified:
7 years, 9 months ago

Reviewers:
Alexei Svitkine (slow)

CC:
chromium-reviews, derat+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Fix missing FontConfig calls in default-font code. This adds FcConfigSubstitute() and FcDefaultSubstitute() calls to the code that queries FontConfig to determine whether subpixel rendering should be used for UI text. Per FcFontMatch()'s documentation, these functions must be called; without them, FontConfig now claims that subpixel rendering is disabled. BUG=223379 TBR=asvitkine@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190226

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	ui/gfx/font_render_params_linux.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/12947005/1

7 years, 9 months ago (2013-03-23 19:11:47 UTC) #2

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=126749

7 years, 9 months ago (2013-03-23 22:42:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/12947005/1

7 years, 9 months ago (2013-03-23 22:54:02 UTC) #4

Message was sent while issue was closed.

Change committed as 190226

Expand Messages | Collapse Messages