bluetooth: Add histograms for readValue and writeValue outcomes

bluetooth: Add histograms for readValue and writeValue outcomes

Histograms added:
 - Characteristic.ReadValue.Outcome: Outcome of a call to readValue
 - Characteristic.WriteValue.Outcome: Outcome of a call to writeValue

BUG=499636
Committed: https://crrev.com/76e9ded7abdc1ce194ff6aea3be32a30246a9c37
Cr-Commit-Position: refs/heads/master@{#343538}

[ortuno, 2015-08-14 18:46:40]

ortuno@chromium.org changed reviewers:
+ jyasskin@chromium.org

[ortuno, 2015-08-14 18:46:40]

@jyasskin: PTAL

[Jeffrey Yasskin, 2015-08-14 21:33:22]

LGTM

https://codereview.chromium.org/1294473006/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/1294473006/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:727: //
TranslateGATTError calls RecordGATTOperationOutcome with
This comment could be shorter: "TranslateGATTError calls
RecordGATTOperationOutcome."

https://codereview.chromium.org/1294473006/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_metrics.cc (left):

https://codereview.chromium.org/1294473006/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_metrics.cc:145:
UMA_HISTOGRAM_ENUMERATION("Bluetooth.GATTErrors", static_cast<int>(error),
Mark this histogram as deprecated.

[ortuno, 2015-08-14 21:42:20]

Thanks!

https://codereview.chromium.org/1294473006/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/1294473006/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:727: //
TranslateGATTError calls RecordGATTOperationOutcome with
On 2015/08/14 at 21:33:22, Jeffrey Yasskin wrote:
> This comment could be shorter: "TranslateGATTError calls
RecordGATTOperationOutcome."

Done.

https://codereview.chromium.org/1294473006/diff/1/content/browser/bluetooth/b...
File content/browser/bluetooth/bluetooth_metrics.cc (left):

https://codereview.chromium.org/1294473006/diff/1/content/browser/bluetooth/b...
content/browser/bluetooth/bluetooth_metrics.cc:145:
UMA_HISTOGRAM_ENUMERATION("Bluetooth.GATTErrors", static_cast<int>(error),
On 2015/08/14 at 21:33:22, Jeffrey Yasskin wrote:
> Mark this histogram as deprecated.

Done.

[ortuno, 2015-08-14 21:42:57]

ortuno@chromium.org changed reviewers:
+ asvitkine@chromium.org, scheib@chromium.org

[ortuno, 2015-08-14 21:42:58]

@scheib: PTAL
@asvitkine: PTAL at histograms.xml

[scheib, 2015-08-14 22:13:30]

LGTM

[ortuno, 2015-08-14 22:15:11]

ortuno@chromium.org changed reviewers:
+ isherman@chromium.org
- asvitkine@chromium.org

[ortuno, 2015-08-14 22:15:11]

@isherman: asvitkine is OOO. Could you take a look at histograms.xml?

[Ilya Sherman, 2015-08-14 22:27:50]

histograms LGTM % nits:

https://codereview.chromium.org/1294473006/diff/20001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_metrics.h (right):

https://codereview.chromium.org/1294473006/diff/20001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_metrics.h:137: // Some of the
nit: Sentence fragment.  Consider revising ;)

https://codereview.chromium.org/1294473006/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1294473006/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2766: +    Records the outcome of a call
to characteristic.readValue(). Use to know
nit: "Use to know" -> "Used to know"

https://codereview.chromium.org/1294473006/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2768: +    how common this errors are
and if we need to provide better error messages
nit: "this errors" -> "these errors"

https://codereview.chromium.org/1294473006/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2782: +    to the users.
(Same nits apply here as well.)

[ortuno, 2015-08-14 22:35:03]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-08-14 22:35:03]

Thanks!

https://codereview.chromium.org/1294473006/diff/20001/content/browser/bluetoo...
File content/browser/bluetooth/bluetooth_metrics.h (right):

https://codereview.chromium.org/1294473006/diff/20001/content/browser/bluetoo...
content/browser/bluetooth/bluetooth_metrics.h:137: // Some of the
On 2015/08/14 at 22:27:50, Ilya Sherman wrote:
> nit: Sentence fragment.  Consider revising ;)

Done.

https://codereview.chromium.org/1294473006/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1294473006/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2766: +    Records the outcome of a call
to characteristic.readValue(). Use to know
On 2015/08/14 at 22:27:50, Ilya Sherman wrote:
> nit: "Use to know" -> "Used to know"

Done.

https://codereview.chromium.org/1294473006/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2768: +    how common this errors are
and if we need to provide better error messages
On 2015/08/14 at 22:27:50, Ilya Sherman wrote:
> nit: "this errors" -> "these errors"

Done.

https://codereview.chromium.org/1294473006/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:2782: +    to the users.
On 2015/08/14 at 22:27:50, Ilya Sherman wrote:
> (Same nits apply here as well.)

Done.

[ortuno, 2015-08-14 22:35:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
jyasskin@chromium.org, isherman@chromium.org, scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/1294473006/#ps40001
(title: "Fix typos")

[ortuno, 2015-08-14 22:35:04]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-08-14 22:35:05]

Thanks!

[commit-bot: I haz the power, 2015-08-14 22:35:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1294473006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1294473006/40001

[commit-bot: I haz the power, 2015-08-15 02:48:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-15 02:49:52]

Patchset 3 (id:??) landed as
https://crrev.com/76e9ded7abdc1ce194ff6aea3be32a30246a9c37
Cr-Commit-Position: refs/heads/master@{#343538}