Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2305)

Unified Diff: chrome/browser/resources/apps_debugger/js/items_list.js

Issue 12943010: Add native permissions dialog for apps_devtools app. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/apps_debugger/js/items_list.js
diff --git a/chrome/browser/resources/apps_debugger/js/items_list.js b/chrome/browser/resources/apps_debugger/js/items_list.js
index 8896b7b165027b344cabd3b496e096c7ecf91472..a0b80d719a966b3c5f1a302e9d99b9793ee2d577 100644
--- a/chrome/browser/resources/apps_debugger/js/items_list.js
+++ b/chrome/browser/resources/apps_debugger/js/items_list.js
@@ -276,23 +276,7 @@ cr.define('apps_dev_tool', function() {
setPermissionsLink_: function(item, el) {
var permissions = el.querySelector('.permissions-link');
permissions.addEventListener('click', function(e) {
- var permissionItem = $('permissions-item');
- permissionItem.textContent = '';
- chrome.management.getPermissionWarningsById(
- item.id,
- function(warnings) {
- warnings.forEach(function(permission) {
- var li = document.createElement('li');
- li.textContent = permission;
- permissionItem.appendChild(li);
- });
- AppsDevTool.showOverlay($('permissions-overlay'));
- });
-
- $('permissions-icon').style.backgroundImage =
- 'url(' + item.icon + ')';
- $('permissions-title').textContent = item.name;
- e.preventDefault();
+ chrome.developerPrivate.permissions(item.id);
});
},
@@ -434,8 +418,10 @@ cr.define('apps_dev_tool', function() {
* @param {string} id Item ID.
*/
ItemsList.launchApp = function(id) {
- chrome.management.launchApp(id);
- ItemsList.loadItemsInfo();
+ chrome.management.launchApp(id, function() {
+ // There is a delay in generation of background page for the app.
+ setTimeout(ItemsList.loadItemsInfo, 1000);
Dan Beam 2013/03/20 19:55:33 so... where'd we land on making this an event inst
Gaurav 2013/03/20 21:01:15 I think this came from another CL (CL or CL), Sorr
Dan Beam 2013/03/20 21:47:28 No. A better temp solution is to poll on an interv
Gaurav 2013/03/27 19:07:17 Removed for this CL.
+ });
};
return {

Powered by Google App Engine
This is Rietveld 408576698