Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 12943007: Don't call SkGpuDevice::drawVertices from drawPoints when AA is required. (Closed)

Created:
7 years, 9 months ago by bsalomon
Modified:
7 years, 4 months ago
Reviewers:
jvanverth1, djsollen
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Don't call SkGpuDevice::drawVertices from drawPoints when AA is required. R=jvanverth@google.com Committed: http://code.google.com/p/skia/source/detail?r=10489

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/gpu/SkGpuDevice.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bsalomon
Adding AA support to drawVertices is still a low-priority TODO. It isn't called by WebKit ...
7 years, 9 months ago (2013-03-20 14:26:10 UTC) #1
jvanverth1
lgtm
7 years, 9 months ago (2013-03-20 14:44:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/12943007/3001
7 years, 4 months ago (2013-08-01 17:10:48 UTC) #3
commit-bot: I haz the power
Change committed as 10489
7 years, 4 months ago (2013-08-01 17:30:36 UTC) #4
djsollen
7 years, 4 months ago (2013-08-01 18:36:50 UTC) #5
Message was sent while issue was closed.
This was reverted due to GM failures.

https://codereview.chromium.org/21496003

Powered by Google App Engine
This is Rietveld 408576698