Fix libcxx build.

Fix libcxx build.

In libcxx, vector<bool>::const_reference is not the same as bool. This requires
a new specialization of ParamTraits.

BUG=178409
R=tsepez@chromium.org,agl@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189383

[agl, 2013-03-20 13:55:54]

lgtm

[commit-bot: I haz the power, 2013-03-20 14:07:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eugenis@chromium.org/12943006/1

[commit-bot: I haz the power, 2013-03-20 14:16:02]

Sorry for I got bad news for ya.
Compile failed with a clobber build on ios_dbg_simulator.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[eugenis, 2013-03-20 14:57:48]

with libstdc+++ (and probably stlport) bool and
std::vector<bool>::const_reference are the same type, and we end up with
duplicate specializations. I've added an #ifdef to work around this.

Alternatively, I could add explicit casts to (bool) whenever an element of a
bool vector is passed to ParamTraits methods - there are only 2 places like
that. Let me know if you prefer this.

PTAL.

[agl, 2013-03-20 14:59:43]

On Wed, Mar 20, 2013 at 10:57 AM,  <eugenis@chromium.org> wrote:
> Alternatively, I could add explicit casts to (bool) whenever an element of a
> bool vector is passed to ParamTraits methods - there are only 2 places like
> that. Let me know if you prefer this.

^ it does sound like that might be a much smaller patch.


Cheers

AGL

[eugenis, 2013-03-20 15:18:32]

On 2013/03/20 14:59:43, agl wrote:
> On Wed, Mar 20, 2013 at 10:57 AM,  <mailto:eugenis@chromium.org> wrote:
> > Alternatively, I could add explicit casts to (bool) whenever an element of a
> > bool vector is passed to ParamTraits methods - there are only 2 places like
> > that. Let me know if you prefer this.
> 
> ^ it does sound like that might be a much smaller patch.

Yes.

[agl, 2013-03-20 15:22:06]

lgtm

[commit-bot: I haz the power, 2013-03-20 16:09:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eugenis@chromium.org/12943006/12001

[Tom Sepez, 2013-03-20 17:10:48]

lgtm

[commit-bot: I haz the power, 2013-03-20 20:25:05]

Change committed as 189383