Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1710)

Unified Diff: content/child/service_worker/service_worker_network_provider.cc

Issue 1294243004: PlzNavigate: Make ServiceWorker work with PlzNavigate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/service_worker/service_worker_network_provider.cc
diff --git a/content/child/service_worker/service_worker_network_provider.cc b/content/child/service_worker/service_worker_network_provider.cc
index a21c08f87fb70dec994c1583609cb0da1da7c04c..ce15ac614d868ddca1a129aee2b59c52b4344968 100644
--- a/content/child/service_worker/service_worker_network_provider.cc
+++ b/content/child/service_worker/service_worker_network_provider.cc
@@ -5,9 +5,12 @@
#include "content/child/service_worker/service_worker_network_provider.h"
#include "base/atomic_sequence_num.h"
+#include "base/command_line.h"
#include "content/child/child_thread_impl.h"
#include "content/child/service_worker/service_worker_provider_context.h"
#include "content/common/service_worker/service_worker_messages.h"
+#include "content/common/service_worker/service_worker_utils.h"
+#include "content/public/common/content_switches.h"
namespace content {
@@ -46,17 +49,40 @@ ServiceWorkerNetworkProvider* ServiceWorkerNetworkProvider::FromDocumentState(
ServiceWorkerNetworkProvider::ServiceWorkerNetworkProvider(
int route_id,
- ServiceWorkerProviderType provider_type)
- : provider_id_(GenerateProviderIdForType(provider_type)) {
+ ServiceWorkerProviderType provider_type,
+ int browser_provider_id) {
+ provider_id_ = kInvalidServiceWorkerProviderId;
+ if (ServiceWorkerUtils::IsBrowserAssignedProviderId(browser_provider_id)) {
+ // PlzNavigate
+ CHECK(base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kEnableBrowserSideNavigation));
+ DCHECK_NE(SERVICE_WORKER_PROVIDER_FOR_SANDBOXED_FRAME, provider_type);
+ // This is a navigation. The ServiceWorkerProviderHost has already been
+ // initialized, copy the provider_id value.
+ provider_id_ = browser_provider_id;
+ } else {
+ // Initialize a new provider ID in all other cases.
+ DCHECK_EQ(kInvalidServiceWorkerProviderId, browser_provider_id);
+ provider_id_ = GenerateProviderIdForType(provider_type);
+ }
if (provider_id_ == kInvalidServiceWorkerProviderId)
return;
+
context_ = new ServiceWorkerProviderContext(provider_id_);
if (!ChildThreadImpl::current())
return; // May be null in some tests.
+
ChildThreadImpl::current()->Send(new ServiceWorkerHostMsg_ProviderCreated(
provider_id_, route_id, provider_type));
}
+ServiceWorkerNetworkProvider::ServiceWorkerNetworkProvider(
+ int route_id,
+ ServiceWorkerProviderType provider_type)
+ : ServiceWorkerNetworkProvider(route_id,
+ provider_type,
+ kInvalidServiceWorkerProviderId) {}
+
ServiceWorkerNetworkProvider::~ServiceWorkerNetworkProvider() {
if (provider_id_ == kInvalidServiceWorkerProviderId)
return;

Powered by Google App Engine
This is Rietveld 408576698