Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3836)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogTitleView.java

Issue 12942004: Add Glue as delegate to AutofillDialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Static fix Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogGlue.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogTitleView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogTitleView.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogTitleView.java
index 03e22e5744434a4b10da8a148aafe15270338a57..7e9df4dd0ffd0b2e4455077689eb048ab6fd89d4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogTitleView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogTitleView.java
@@ -5,7 +5,6 @@
package org.chromium.chrome.browser.autofill;
import java.util.ArrayList;
-import java.util.List;
import android.content.Context;
import android.view.LayoutInflater;
@@ -24,9 +23,8 @@ import org.chromium.chrome.R;
* the content.
*/
public class AutofillDialogTitleView extends FrameLayout {
- private static final List<String> mConstantItems = new ArrayList<String>();
- private List<String> mAccountNames;
+ private ArrayList<String> mAccountNames;
private ArrayAdapter<String> mAdapter;
/**
@@ -35,17 +33,12 @@ public class AutofillDialogTitleView extends FrameLayout {
*/
public AutofillDialogTitleView(Context context) {
super(context);
- if (mConstantItems.isEmpty()) {
- mConstantItems.add(getResources().getString(R.string.autofill_new_account));
- mConstantItems.add(getResources().getString(R.string.autofill_use_local));
- }
LayoutInflater.from(context).inflate(R.layout.autofill_dialog_title, this, true);
- Spinner accounts_spinner = (Spinner)findViewById(R.id.accounts_spinner);
+ Spinner accountsSpinner = (Spinner)findViewById(R.id.accounts_spinner);
mAdapter = new ArrayAdapter<String>(context, android.R.layout.simple_spinner_item);
mAdapter.setDropDownViewResource(android.R.layout.simple_spinner_dropdown_item);
- mAdapter.addAll(mConstantItems);
- accounts_spinner.setAdapter(mAdapter);
+ accountsSpinner.setAdapter(mAdapter);
}
/**
@@ -53,12 +46,28 @@ public class AutofillDialogTitleView extends FrameLayout {
* @param context The context to create the title within.
* @param accountNames The dropdown items to be listed.
*/
- public AutofillDialogTitleView(Context context, List<String> accountNames) {
+ public AutofillDialogTitleView(Context context, ArrayList<String> accountNames) {
this(context);
- mAccountNames = accountNames;
+ updateAccountsAndSelect(accountNames, 0);
+ }
+
+ /**
+ * Update account chooser dropdown with given accounts and create the title view if needed.
+ * @param accountNames The dropdown items to be listed.
+ * @param selectedAccountIndex The index of a currently selected account or -1
+ * if the local payments should be used.
+ */
+ public void updateAccountsAndSelect(ArrayList<String> accountNames,
+ int selectedAccountIndex) {
mAdapter.clear();
+ mAccountNames = accountNames;
mAdapter.addAll(mAccountNames);
- mAdapter.addAll(mConstantItems);
+ Spinner accountsSpinner = (Spinner)findViewById(R.id.accounts_spinner);
+ if (selectedAccountIndex >= 0) {
+ accountsSpinner.setSelection(selectedAccountIndex);
+ } else {
+ accountsSpinner.setSelection(accountsSpinner.getCount() - 1);
+ }
}
/**
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogGlue.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698