Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 12941002: Invoke python correctly from windows. (Closed)

Created:
7 years, 9 months ago by szager1
Modified:
7 years, 9 months ago
Reviewers:
iannucci, M-A Ruel, scottmg
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Visibility:
Public.

Description

Invoke python correctly from windows. BUG=158663 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=189084

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M git-runhooks View 1 chunk +8 lines, -1 line 2 comments Download

Messages

Total messages: 7 (0 generated)
szager1
I prefer this to: https://codereview.chromium.org/12494021 ... because it changes only the code used by the ...
7 years, 9 months ago (2013-03-19 20:17:41 UTC) #1
scottmg
I only understand about half of those escapes, so I'm going to leave this to ...
7 years, 9 months ago (2013-03-19 20:21:17 UTC) #2
iannucci
drive-by :). This lgtm (assuming you tested on mingw) https://codereview.chromium.org/12941002/diff/1/git-runhooks File git-runhooks (right): https://codereview.chromium.org/12941002/diff/1/git-runhooks#newcode17 git-runhooks:17: ...
7 years, 9 months ago (2013-03-19 20:29:23 UTC) #3
szager1
https://codereview.chromium.org/12941002/diff/1/git-runhooks File git-runhooks (right): https://codereview.chromium.org/12941002/diff/1/git-runhooks#newcode17 git-runhooks:17: dir="${0%\\*}" On 2013/03/19 20:29:24, iannucci wrote: > why not ...
7 years, 9 months ago (2013-03-19 20:31:37 UTC) #4
iannucci
On 2013/03/19 20:31:37, szager1 wrote: > https://codereview.chromium.org/12941002/diff/1/git-runhooks > File git-runhooks (right): > > https://codereview.chromium.org/12941002/diff/1/git-runhooks#newcode17 > ...
7 years, 9 months ago (2013-03-19 20:34:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/12941002/1
7 years, 9 months ago (2013-03-19 20:35:37 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-19 20:38:11 UTC) #7
Message was sent while issue was closed.
Change committed as 189084

Powered by Google App Engine
This is Rietveld 408576698