content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java - Issue 12939021: Make the build control what library(/ies) to load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

Issue 12939021: Make the build control what library(/ies) to load (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@antpy

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ChildProcessConnection.java ('k') | content/public/android/java/templates/NativeLibraries.template » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

index 5ddc008e5f705d251e2e6a202219720e105a8ec7..92669a64ffbe1b0763c40599c6c927181ac433ba 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncher.java

@@ -18,7 +18,6 @@ import org.chromium.base.ThreadUtils;

import org.chromium.content.app.ChildProcessService;

import org.chromium.content.app.PrivilegedProcessService;

import org.chromium.content.app.SandboxedProcessService;

-import org.chromium.content.app.LibraryLoader;

import org.chromium.content.common.IChildProcessCallback;

import org.chromium.content.common.IChildProcessService;

@@ -155,10 +154,7 @@ public class ChildProcessLauncher {

String[] commandLine, boolean inSandbox) {

ChildProcessConnection connection = allocateConnection(context, inSandbox);

if (connection != null) {

- String libraryName = LibraryLoader.getLibraryToLoad();

- assert libraryName != null : "Attempting to launch a child process without first "

- + "calling LibraryLoader.setLibraryToLoad";

- connection.bind(libraryName, commandLine);

+ connection.bind(commandLine);

}

return connection;

}