Issue 12939015: Fix sizing when auto-scaling a missing resource at a non-integer scale factor.

Issue 12939015: Fix sizing when auto-scaling a missing resource at a non-integer scale factor. (Closed)

Created:
7 years, 9 months ago by kevers

Modified:
7 years, 8 months ago

Reviewers:
tony

CC:
chromium-reviews, oshima

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Fix sizing when auto-scaling a missing resource at a non-integer scale factor. Matches the rounding rules used by UX when scaling resources at non-integer scale factors. BUG=223928 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190970 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192576

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -2 lines)			Patch
	M	ui/base/resource/resource_bundle.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	ui/base/resource/resource_bundle_unittest.cc	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download

Total messages: 8 (0 generated)

kevers

On 2013/03/26 17:03:16, tony wrote: > LGTM. Should there be a unit test for this? ...

7 years, 9 months ago (2013-03-26 18:43:16 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/12939015/4001

7 years, 9 months ago (2013-03-27 14:29:50 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/12939015/34001

7 years, 8 months ago (2013-04-05 13:54:17 UTC) #7

Message was sent while issue was closed.

Change committed as 192576