Issue 12937009: renaming File to Source

Issue 12937009: renaming File to Source (Closed)

Created:
7 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
7 years, 9 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/source-maps.git@master

Visibility:
Public.

More Reviews

Description

renaming File to Source Committed: https://github.com/dart-lang/source-maps/commit/1e79a23

Patch Set 4 : #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -61 lines)			Patch
M	lib/builder.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/parser.dart	View	1 2 3	3 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/source_maps.dart	View		1 chunk	+1 line, -1 line	2 comments	Download
	lib/span.dart	View	1 2 3	12 chunks	+46 lines, -47 lines	0 comments	Download
	pubspec.yaml	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/common.dart	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/end2end_test.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	test/span_test.dart	View	1 2 3	4 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

I'm not entirely convinced about the new name though. Mainly because in a source-map I ...

7 years, 9 months ago (2013-03-20 19:55:23 UTC) #1

Jennifer Messerly

I think Buffer could be confusing with a byte buffer or something like that... Maybe ...

7 years, 9 months ago (2013-03-20 20:00:49 UTC) #2

Siggi Cherem (dart-lang)

ptal - renamed to SourceFile, left FileSpan and FileLocation as they were. ALso changed pubspec ...

7 years, 9 months ago (2013-03-20 22:10:12 UTC) #3

Jennifer Messerly

lgtm https://chromiumcodereview.appspot.com/12937009/diff/7001/lib/source_maps.dart File lib/source_maps.dart (right): https://chromiumcodereview.appspot.com/12937009/diff/7001/lib/source_maps.dart#newcode14 lib/source_maps.dart:14: /// Use the [Span] and [Source] classes to ...

7 years, 9 months ago (2013-03-20 22:11:46 UTC) #4

Siggi Cherem (dart-lang)

Committed patchset #4 manually as r1e79a23 (presubmit successful).

7 years, 9 months ago (2013-03-20 22:33:54 UTC) #5

Siggi Cherem (dart-lang)

7 years, 9 months ago (2013-03-20 22:35:24 UTC) #6

Message was sent while issue was closed.

thx

https://chromiumcodereview.appspot.com/12937009/diff/7001/lib/source_maps.dart
File lib/source_maps.dart (right):

https://chromiumcodereview.appspot.com/12937009/diff/7001/lib/source_maps.dar...
lib/source_maps.dart:14: /// Use the [Span] and [Source] classes to specify span
locations.
On 2013/03/20 22:11:46, John Messerly wrote:
> SourceFile?

Done.

Expand Messages | Collapse Messages