Issue 12937008: Move HoverButton and HoverImageButton from chrome/browser/ui/cocoa/ to ui/base/cocoa.

Issue 12937008: Move HoverButton and HoverImageButton from chrome/browser/ui/cocoa/ to ui/base/cocoa. (Closed)

Created:
7 years, 9 months ago by Robert Sesek

Modified:
7 years, 9 months ago

Reviewers:
sail, sky

CC:
chromium-reviews, asanka, jennb, benjhayden+dwatch_chromium.org, jianli, Randy Smith (Not in Mondays), sail+watch_chromium.org, Dmitry Titov, dcheng

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move HoverButton and HoverImageButton from chrome/browser/ui/cocoa/ to ui/base/cocoa. HoverImageButton will be needed by ui/message_center, and ImageButtonCell does not extract well from chrome/ because of a dependence on ThemeWindow. BUG=179904 TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189314

Patch Set 1 #

Patch Set 2 : '' #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -355 lines)			Patch
M	chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/browser/zoom_bubble_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_shelf_controller.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
D	chrome/browser/ui/cocoa/hover_button.h	View		1 chunk	+0 lines, -44 lines	0 comments	Download
D	chrome/browser/ui/cocoa/hover_button.mm	View		1 chunk	+0 lines, -106 lines	0 comments	Download
M	chrome/browser/ui/cocoa/hover_close_button.h	View		2 chunks	+7 lines, -1 line	0 comments	Download
D	chrome/browser/ui/cocoa/hover_image_button.h	View		1 chunk	+0 lines, -40 lines	0 comments	Download
D	chrome/browser/ui/cocoa/hover_image_button.mm	View		1 chunk	+0 lines, -52 lines	0 comments	Download
D	chrome/browser/ui/cocoa/hover_image_button_unittest.mm	View		1 chunk	+0 lines, -70 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/action_box_menu_bubble_controller.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/notifications/balloon_controller.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/panels/panel_titlebar_view_cocoa.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_nibs.gyp	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
A +	ui/base/cocoa/hover_button.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A +	ui/base/cocoa/hover_button.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	ui/base/cocoa/hover_image_button.h	View		2 chunks	+7 lines, -2 lines	0 comments	Download
A +	ui/base/cocoa/hover_image_button.mm	View		1 chunk	+1 line, -5 lines	0 comments	Download
A +	ui/base/cocoa/hover_image_button_unittest.mm	View		3 chunks	+7 lines, -14 lines	0 comments	Download
M	ui/ui.gyp	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/ui_unittests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/12937008/5001

7 years, 9 months ago (2013-03-19 21:53:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/12937008/5001

7 years, 9 months ago (2013-03-20 14:07:26 UTC) #5

Message was sent while issue was closed.

Change committed as 189314

Expand Messages | Collapse Messages