android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java - Issue 1292923004: Refactor chrome's action mode logics and namings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java

Issue 1292923004: Refactor chrome's action mode logics and namings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make webview to compile Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java ('k') | android_webview/java/src/org/chromium/android_webview/AwContentsClient.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java

index 880d3a1511f111984a67b95a50aa73784e3c0e60..fb5b55d61172c3e6df7013c188fd97e69eebd631 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java

@@ -13,8 +13,8 @@ import android.widget.FrameLayout;

import org.chromium.content.browser.ContentVideoViewClient;

import org.chromium.content.browser.ContentViewClient;

-import org.chromium.content.browser.SelectActionMode;

-import org.chromium.content.browser.SelectActionModeCallback.ActionHandler;

+import org.chromium.content.browser.WebActionMode;

+import org.chromium.content.browser.WebActionModeCallback.ActionHandler;

/**

* ContentViewClient implementation for WebView

@@ -70,7 +70,7 @@ public class AwContentViewClient extends ContentViewClient implements ContentVid

}

@Override

- public SelectActionMode startActionMode(

+ public WebActionMode startActionMode(

View view, ActionHandler actionHandler, boolean floating) {

return mAwContentsClient.startActionMode(view, actionHandler, floating);

}