chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java - Issue 1292923004: Refactor chrome's action mode logics and namings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 1292923004: Refactor chrome's action mode logics and namings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/CustomSelectionActionModeCallback.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeActionModeCallback.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

index f25528d67e0559f17dfb3798c4fc836a78971639..3803fbb2826307ddbfaa7882f42f85bdaa734304 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

@@ -179,7 +179,7 @@ public class CustomTabActivity extends ChromeActivity {

initializeCompositorContent(layoutDriver, findViewById(R.id.url_bar),

(ViewGroup) findViewById(android.R.id.content), controlContainer);

mFindToolbarManager = new FindToolbarManager(this, getTabModelSelector(),

- getToolbarManager().getContextualMenuBar().getCustomSelectionActionModeCallback());

+ getToolbarManager().getActionModeController().getActionModeCallback());

getToolbarManager().initializeWithNative(getTabModelSelector(), getFullscreenManager(),

mFindToolbarManager, null, layoutDriver, null, null, null,

new OnClickListener() {