android_webview/java/src/org/chromium/android_webview/AwContentsClient.java - Issue 1292923004: Refactor chrome's action mode logics and namings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 1292923004: Refactor chrome's action mode logics and namings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContentViewClient.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/TestAwContentsClient.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeActionModeCallback.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

index e23285d35ed1a8d238da0001f62fbb74e3457d69..153cc820ab4526c1e4fbcb43d5e34065f75baf4b 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

@@ -28,8 +28,8 @@ import org.chromium.android_webview.permission.AwPermissionRequest;

import org.chromium.base.Log;

import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.content.browser.ContentViewCore;

-import org.chromium.content.browser.SelectActionMode;

-import org.chromium.content.browser.SelectActionModeCallback.ActionHandler;

+import org.chromium.content.browser.WebActionMode;

+import org.chromium.content.browser.WebActionModeCallback.ActionHandler;

import java.security.Principal;

import java.util.HashMap;

@@ -373,7 +373,7 @@ public abstract class AwContentsClient {

public abstract void onNewPicture(Picture picture);

- public abstract SelectActionMode startActionMode(

+ public abstract WebActionMode startActionMode(

View view, ActionHandler actionHandler, boolean floating);

public abstract boolean supportsFloatingActionMode();