Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1292913002: Split off serialization and key functions to their own packages. (Closed)

Created:
5 years, 4 months ago by iannucci
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://github.com/luci/gae.git@make_queries_better
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Split off serialization and key functions to their own packages. This makes the service/datastore package smaller and more single-purpose. R=dnj@google.com, dnj@chromium.org, estaab@chromium.org, tandrii@chromium.org, vadimsh@chromium.org BUG= Committed: https://github.com/luci/gae/commit/cdfcaecbfba559baec9b7260399b67c3298f9eae

Patch Set 1 #

Total comments: 5

Patch Set 2 : fix comments #

Patch Set 3 : rebase #

Patch Set 4 : remove print statement :) #

Patch Set 5 : and the import.... #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+923 lines, -2008 lines) Patch
M filter/dscache/dscache.go View 2 chunks +2 lines, -4 lines 0 comments Download
M filter/dscache/dscache_test.go View 3 chunks +3 lines, -4 lines 0 comments Download
M filter/dscache/serialize.go View 3 chunks +3 lines, -4 lines 0 comments Download
M filter/dscache/support.go View 2 chunks +4 lines, -4 lines 0 comments Download
M impl/dummy/dummy.go View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M impl/memory/datastore.go View 3 chunks +5 lines, -4 lines 0 comments Download
M impl/memory/datastore_data.go View 13 chunks +25 lines, -25 lines 0 comments Download
M impl/memory/datastore_index.go View 6 chunks +9 lines, -14 lines 0 comments Download
M impl/memory/datastore_query.go View 1 2 4 chunks +5 lines, -8 lines 0 comments Download
M impl/memory/datastore_test.go View 1 2 3 4 5 6 chunks +10 lines, -11 lines 0 comments Download
M impl/memory/testing_utils_test.go View 3 chunks +7 lines, -5 lines 0 comments Download
M impl/prod/datastore_key.go View 3 chunks +10 lines, -2 lines 0 comments Download
M service/datastore/checkfilter.go View 3 chunks +3 lines, -7 lines 0 comments Download
M service/datastore/checkfilter_test.go View 4 chunks +9 lines, -9 lines 0 comments Download
M service/datastore/context_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M service/datastore/datastore_test.go View 3 chunks +9 lines, -5 lines 0 comments Download
A service/datastore/dskey/doc.go View 1 chunk +8 lines, -0 lines 0 comments Download
A service/datastore/dskey/generic_key.go View 1 1 chunk +122 lines, -0 lines 0 comments Download
A + service/datastore/dskey/key.go View 1 2 3 4 11 chunks +46 lines, -34 lines 0 comments Download
A + service/datastore/dskey/key_test.go View 6 chunks +65 lines, -51 lines 0 comments Download
D service/datastore/generic_key.go View 1 chunk +0 lines, -105 lines 0 comments Download
M service/datastore/index.go View 2 chunks +80 lines, -12 lines 0 comments Download
M service/datastore/index_test.go View 2 chunks +0 lines, -48 lines 0 comments Download
D service/datastore/invertible.go View 1 chunk +0 lines, -115 lines 0 comments Download
D service/datastore/invertible_test.go View 1 chunk +0 lines, -89 lines 0 comments Download
D service/datastore/key.go View 1 chunk +0 lines, -232 lines 0 comments Download
D service/datastore/key_test.go View 1 chunk +0 lines, -243 lines 0 comments Download
M service/datastore/pls_test.go View 4 chunks +121 lines, -36 lines 0 comments Download
M service/datastore/raw_interface.go View 1 chunk +17 lines, -0 lines 0 comments Download
D service/datastore/serialize.go View 1 2 3 4 5 1 chunk +0 lines, -470 lines 0 comments Download
A service/datastore/serialize/doc.go View 1 chunk +7 lines, -0 lines 0 comments Download
A + service/datastore/serialize/invertible.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/serialize/invertible_test.go View 1 chunk +1 line, -1 line 0 comments Download
A + service/datastore/serialize/serialize.go View 1 2 3 4 5 18 chunks +170 lines, -80 lines 0 comments Download
A + service/datastore/serialize/serialize_test.go View 12 chunks +177 lines, -52 lines 0 comments Download
D service/datastore/serialize_test.go View 1 chunk +0 lines, -330 lines 0 comments Download

Depends on Patchset:

Issue 1286943002 Patch 100001

Dependent Patchsets:

Issue 1300493002 Patch 20001
Issue 1300493002 Patch 40001

Messages

Total messages: 6 (1 generated)
iannucci
5 years, 4 months ago (2015-08-14 20:53:00 UTC) #1
dnj (Google)
LGTM w/ nits. https://codereview.chromium.org/1292913002/diff/1/service/datastore/dskey/generic_key.go File service/datastore/dskey/generic_key.go (right): https://codereview.chromium.org/1292913002/diff/1/service/datastore/dskey/generic_key.go#newcode60 service/datastore/dskey/generic_key.go:60: func (k *Generic) lastTok() (ret ds.KeyTok) ...
5 years, 4 months ago (2015-08-14 21:19:50 UTC) #3
iannucci
https://chromiumcodereview.appspot.com/1292913002/diff/1/service/datastore/dskey/generic_key.go File service/datastore/dskey/generic_key.go (right): https://chromiumcodereview.appspot.com/1292913002/diff/1/service/datastore/dskey/generic_key.go#newcode60 service/datastore/dskey/generic_key.go:60: func (k *Generic) lastTok() (ret ds.KeyTok) { On 2015/08/14 ...
5 years, 4 months ago (2015-08-14 22:13:03 UTC) #4
dnj (Google)
https://chromiumcodereview.appspot.com/1292913002/diff/1/service/datastore/dskey/key.go File service/datastore/dskey/key.go (right): https://chromiumcodereview.appspot.com/1292913002/diff/1/service/datastore/dskey/key.go#newcode22 service/datastore/dskey/key.go:22: // Encode encodes the provided key as a base64-encoded ...
5 years, 4 months ago (2015-08-14 22:23:17 UTC) #5
iannucci
5 years, 4 months ago (2015-08-15 21:53:54 UTC) #6
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) manually as
cdfcaecbfba559baec9b7260399b67c3298f9eae (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698