Load sync token upon login

Load sync token upon login for locally managed user


BUG=176277
TBR=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190464

[Nikita (slow), 2013-03-25 12:16:23]

lgtm with nits

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/login_utils.cc (right):

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/login_utils.cc:273: login_host);
nit: Please align params

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/managed/locally_managed_user_creation_flow.h
(right):

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_creation_flow.h:28:
LoginDisplayHost* host) OVERRIDE;
nit: Alignment

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc
(right):

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:33:
void LocallyManagedUserLoginFlow::RegisterPrefs(PrefRegistrySimple* registry) {
As discussed makes sense to comment code that stores token in Prefs for now.

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:52:
return true;
As far as I could see this will lead to skipping user image selection screen
which now still is part of LMU sign in flow.
Makes sense to return false here till this step is moved to user creation part?

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:68: 
nit: Remove empty line.

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:70: 
nit: Remove empty line.

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:85:
PrefService* prefs = profile_->GetPrefs();
nit: Lines 85-87 should be commented.

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:93: //
ToDo(antrim): Propagate token when we know API.
nit: TODO format is as follows

// TODO(ldap): Capitalized sentence comment here.

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:104: 
nit: drop empty line

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:119: 
nit: drop empty line

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.h
(right):

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.h:15: //
UserFlow implementation for loggin in locally managed user.
nit: signing in

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/user_flow.cc (right):

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/user_flow.cc:18: }
nit: // namespace

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/user_flow.cc:42: LoginDisplayHost* host) {
nit: align

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
File chrome/browser/chromeos/login/user_flow.h (right):

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/user_flow.h:49: virtual void DeleteSoon();
nit: Rename to smth like UnregisterFlow()

https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
chrome/browser/chromeos/login/user_flow.h:50: virtual std::string UserId();
user_id() {
  return user_ud_;
}

[Denis Kuznetsov (DE-MUC), 2013-03-25 13:33:42]

On 2013/03/25 12:16:23, Nikita Kostylev wrote:
> lgtm with nits
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> File chrome/browser/chromeos/login/login_utils.cc (right):
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/login_utils.cc:273: login_host);
> nit: Please align params
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> File
chrome/browser/chromeos/login/managed/locally_managed_user_creation_flow.h
> (right):
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/managed/locally_managed_user_creation_flow.h:28:
> LoginDisplayHost* host) OVERRIDE;
> nit: Alignment
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> File chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc
> (right):
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:33:
> void LocallyManagedUserLoginFlow::RegisterPrefs(PrefRegistrySimple* registry)
{
> As discussed makes sense to comment code that stores token in Prefs for now.
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:52:
> return true;
> As far as I could see this will lead to skipping user image selection screen
> which now still is part of LMU sign in flow.
> Makes sense to return false here till this step is moved to user creation
part?
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:68: 
> nit: Remove empty line.
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:70: 
> nit: Remove empty line.
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:85:
> PrefService* prefs = profile_->GetPrefs();
> nit: Lines 85-87 should be commented.
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:93:
//
> ToDo(antrim): Propagate token when we know API.
> nit: TODO format is as follows
> 
> // TODO(ldap): Capitalized sentence comment here.
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:104: 
> nit: drop empty line
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.cc:119: 
> nit: drop empty line
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> File chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.h
> (right):
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/managed/locally_managed_user_login_flow.h:15: //
> UserFlow implementation for loggin in locally managed user.
> nit: signing in
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> File chrome/browser/chromeos/login/user_flow.cc (right):
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/user_flow.cc:18: }
> nit: // namespace
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/user_flow.cc:42: LoginDisplayHost* host) {
> nit: align
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> File chrome/browser/chromeos/login/user_flow.h (right):
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/user_flow.h:49: virtual void DeleteSoon();
> nit: Rename to smth like UnregisterFlow()
> 
>
https://codereview.chromium.org/12929026/diff/1/chrome/browser/chromeos/login...
> chrome/browser/chromeos/login/user_flow.h:50: virtual std::string UserId();
> user_id() {
>   return user_ud_;
> }

Fixed all nits.

[commit-bot: I haz the power, 2013-03-25 13:37:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/12929026/5002

[commit-bot: I haz the power, 2013-03-25 13:37:27]

Presubmit check for 12929026-5002 failed and returned exit status 1.

INFO:root:Found 9 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/chrome_browser_chromeos.gypi

Presubmit checks took 1.8s to calculate.

[Denis Kuznetsov (DE-MUC), 2013-03-25 13:43:23]

+brettw for rubber-stamping chrome/chrome_browser_chromeos.gypi.

[commit-bot: I haz the power, 2013-03-25 13:43:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/12929026/5002

[commit-bot: I haz the power, 2013-03-25 14:13:52]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-25 16:27:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/antrim@chromium.org/12929026/7012

[brettw, 2013-03-25 17:21:10]

.gypi lgtm stubber-ramp

[commit-bot: I haz the power, 2013-03-25 20:07:02]

Change committed as 190464