Enhancements to https://codereview.chromium.org/12494033/ for zmo@

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
 
   //
@@ skipping 24 matching lines @@
      * |onShowHomeButtonChanged_|.
      * @type {boolean}
      * @private
      */
     onShowHomeButtonChangedCalled_: false,
 
     /**
      * Track if page initialization is complete.  All C++ UI handlers have the
      * chance to manipulate page content within their InitializePage methods.
      * This flag is set to true after all initializers have been called.
-     * @type (boolean}
+     * @type {boolean}
      * @private
      */
     initializationComplete_: false,
 
     /** @override */
     initializePage: function() {
       OptionsPage.prototype.initializePage.call(this);
       var self = this;
 
       // Ensure that navigation events are unblocked on uber page. A reload of
@@ skipping 404 matching lines @@
       if (cr.isChromeOS) {
         if (loadTimeData.getBoolean('enableKioskSection')) {
           $('kiosk-section').hidden = false;
 
           $('manage-kiosk-apps-button').onclick = function(event) {
             OptionsPage.navigateToPage('kioskAppsOverlay');
           };
         }
       }
 
+      // System section.
+      if (!cr.isChromeOS) {
+        var updateGpuRestartLink = function() {
+          $('gpu-mode-reset-restart').hidden =
+              loadTimeData.getBoolean('gpuModeAtStart') ==
+              $('gpu-mode-checkbox').checked;
+        };
+        $('gpu-mode-checkbox').onchange = updateGpuRestartLink;

[arv (Not doing code reviews), 2013/03/22 14:35:48]

Do you really want to listen to the user changing this? You should probably just
sync this with the underlying preference state. You can do something like
Preferences.getInstance().addEventListener(...)

[Dan Beam, 2013/03/22 19:24:31]

zmo@: yeah, you could do this instead

+        $('gpu-mode-reset-restart-link').onclick = function(event) {
+          event.preventDefault();

[arv (Not doing code reviews), 2013/03/22 14:35:48]

Change to <button> and no need for preventDefault.

[Dan Beam, 2013/03/22 19:24:31]

That would be a little bit awkward where it currently is in the UI.

[arv (Not doing code reviews), 2013/03/22 19:35:02]

We have a class called link-button which styles the button as a link.

+          chrome.send('restartBrowser');
+        };
+        updateGpuRestartLink();

[Dan Beam, 2013/03/22 00:32:56]

^ zmo@: you should set this on page load as well

+      }
+
       if (loadTimeData.getBoolean('managedUsersEnabled') &&
           loadTimeData.getBoolean('profileIsManaged')) {
         $('managed-user-settings-section').hidden = false;
 
         $('open-managed-user-settings-button').onclick = function(event) {
           OptionsPage.navigateToPage('managedUser');
         };
       }
     },
 
@@ skipping 960 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });