Chromium Code Reviews Chromium Code Reviews
Issue 12929018:
Enhancements to https://codereview.chromium.org/12494033/ for zmo@ (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 <div id="settings" class="page" hidden> | 1 <div id="settings" class="page" hidden> |
| 2 <header> | 2 <header> |
| 3 <h1 i18n-content="settingsTitle"></h1> | 3 <h1 i18n-content="settingsTitle"></h1> |
| 4 </header> | 4 </header> |
| 5 <if expr="not pp_ifdef('chromeos')"> | 5 <if expr="not pp_ifdef('chromeos')"> |
| 6 <include src="sync_section.html"> | 6 <include src="sync_section.html"> |
| 7 </if> | 7 </if> |
| 8 <if expr="pp_ifdef('chromeos')"> | 8 <if expr="pp_ifdef('chromeos')"> |
| 9 <section> | 9 <section> |
| 10 <h3 i18n-content="sectionTitleInternet"></h3> | 10 <h3 i18n-content="sectionTitleInternet"></h3> |
| (...skipping 689 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 700 <label for="backgroundModeCheckbox" | 700 <label for="backgroundModeCheckbox" |
| 701 i18n-content="backgroundModeCheckbox"> | 701 i18n-content="backgroundModeCheckbox"> |
| 702 </label> | 702 </label> |
| 703 <span class="controlled-setting-indicator" | 703 <span class="controlled-setting-indicator" |
| 704 pref="background_mode.enabled"> | 704 pref="background_mode.enabled"> |
| 705 </span> | 705 </span> |
| 706 </span> | 706 </span> |
| 707 </span> | 707 </span> |
| 708 </div> | 708 </div> |
| 709 </if> | 709 </if> |
| 710 <if expr="not pp_ifdef('chromeos')"> | |
| 710 <div class="checkbox"> | 711 <div class="checkbox"> |
| 711 <span class="controlled-setting-with-label"> | 712 <span class="controlled-setting-with-label"> |
| 712 <input id="hardwareAccelerationModeCheckbox" | 713 <input id="gpu-mode-checkbox" |
| 713 pref="hardware_acceleration_mode.enabled" type="checkbox"> | 714 pref="hardware_acceleration_mode.enabled" type="checkbox"> |
| 714 <span> | 715 <span> |
| 715 <label for="hardwareAccelerationCheckbox" | 716 <label for="gpu-mode-checkbox" |
| 716 i18n-content="hardwareAccelerationModeCheckbox"> | 717 i18n-content="gpuModeCheckbox"> |
| 717 </label> | 718 </label> |
| 718 <span class="controlled-setting-indicator" | 719 <span id="gpu-mode-reset-restart" |
| 719 pref="hardware_acceleration_mode.enabled"> | 720 i18n-values=".innerHTML:gpuModeResetRestart"> |
|
arv (Not doing code reviews)
2013/03/22 14:35:48
Whenever you see yourself doing .innerHTML you sho
Dan Beam
2013/03/22 19:24:31
Why? Security? This is a trusted source.
| |
| 720 </span> | 721 </span> |
| 721 </span> | 722 </span> |
| 722 </span> | 723 </span> |
| 723 </div> | 724 </div> |
| 725 </if> | |
| 724 </section> | 726 </section> |
| 725 <section id="managed-user-settings-section" hidden> | 727 <section id="managed-user-settings-section" hidden> |
| 726 <h3 i18n-content="managedUsersSectionTitle"></h3> | 728 <h3 i18n-content="managedUsersSectionTitle"></h3> |
| 727 <button id="open-managed-user-settings-button" | 729 <button id="open-managed-user-settings-button" |
| 728 i18n-content="manageProfilesManagedUserSettings"> | 730 i18n-content="manageProfilesManagedUserSettings"> |
| 729 </button> | 731 </button> |
| 730 </section> | 732 </section> |
| 731 </div> <!-- advanced-settings-container --> | 733 </div> <!-- advanced-settings-container --> |
| 732 </div> <!-- advanced-settings --> | 734 </div> <!-- advanced-settings --> |
| 733 <footer> | 735 <footer> |
| 734 <button id="advanced-settings-expander" class="link-button" | 736 <button id="advanced-settings-expander" class="link-button" |
| 735 i18n-content="showAdvancedSettings"> | 737 i18n-content="showAdvancedSettings"> |
| 736 </button> | 738 </button> |
| 737 </footer> | 739 </footer> |
| 738 </div> | 740 </div> |
| OLD | NEW |
