Implemented BluetoothAdapterMac::AddDevices().

device/bluetooth/bluetooth_device_mac.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_device_mac.h"
 
+#import <IObluetooth/objc/IOBluetoothDevice.h>

[Mark Mentovai, 2013/03/19 16:04:35]

Fix capitalization.

[youngki, 2013/03/19 19:04:55]

Done.

+#import <IOBluetooth/objc/IOBluetoothSDPServiceRecord.h>
+
 #include <string>
 
 #include "base/basictypes.h"
+#include "base/hash.h"
+#include "base/stringprintf.h"
+#include "base/strings/sys_string_conversions.h"
 #include "device/bluetooth/bluetooth_out_of_band_pairing_data.h"
 #include "device/bluetooth/bluetooth_service_record_mac.h"
 
 namespace device {
 
-BluetoothDeviceMac::BluetoothDeviceMac()
-    : BluetoothDevice() {
+BluetoothDeviceMac::BluetoothDeviceMac(const IOBluetoothDevice* device)
+    : BluetoothDevice(),
+      device_fingerprint_(ComputeDeviceFingerprint(device)) {
+  name_ = base::SysNSStringToUTF8([device name]);

[Mark Mentovai, 2013/03/19 16:04:35]

You can list all of these in the initializer list.

[youngki, 2013/03/19 19:04:55]

Done.

+  address_ = base::SysNSStringToUTF8([device addressString]);
+  bluetooth_class_ = [device classOfDevice];
+  connected_ = [device isConnected];
+  bonded_ = [device isPaired];
 }
 
 BluetoothDeviceMac::~BluetoothDeviceMac() {
 }
 
+void BluetoothDeviceMac::SetVisible(bool visible) {
+  visible_ = visible;
+}
+
 bool BluetoothDeviceMac::IsPaired() const {
   return false;
 }
 
 const BluetoothDevice::ServiceList& BluetoothDeviceMac::GetServices() const {
   return service_uuids_;
 }
 
 void BluetoothDeviceMac::GetServiceRecords(
     const ServiceRecordsCallback& callback,
@@ skipping 68 matching lines @@
     const ErrorCallback& error_callback) {
   NOTIMPLEMENTED();
 }
 
 void BluetoothDeviceMac::ClearOutOfBandPairingData(
     const base::Closure& callback,
     const ErrorCallback& error_callback) {
   NOTIMPLEMENTED();
 }
 
+// static
+uint32 BluetoothDeviceMac::ComputeDeviceFingerprint(
+    const IOBluetoothDevice* device) {
+  std::string device_string = base::StringPrintf("%s%s%u%s%s",

[Mark Mentovai, 2013/03/19 16:04:35]

For fields without fixed width, can you have the different fields delimited by
some character that can’t appear in the input, to reduce collision and ambiguity
potential?

[youngki, 2013/03/19 19:04:55]

Done.

+      base::SysNSStringToUTF8([device name]).c_str(),
+      base::SysNSStringToUTF8([device addressString]).c_str(),
+      [device classOfDevice],
+      [device isConnected] ? "true" : "false",

[Mark Mentovai, 2013/03/19 16:04:35]

You don’t need to turn these into strings, you can just include them in the
printf with %d.

[youngki, 2013/03/19 19:04:55]

Done.

+      [device isPaired] ? "true" : "false");
+
+  for (IOBluetoothSDPServiceRecord* record in [device services]) {
+    base::StringAppendF(
+        &device_string,
+        "%s%u",
+        base::SysNSStringToUTF8([record getServiceName]).c_str(),
+        [[record sortedAttributes] count]);

[Mark Mentovai, 2013/03/19 16:04:35]

If you’re just getting a count, you don’t care if the attributes are sorted or
not.

[youngki, 2013/03/19 19:04:55]

Done.

+  }
+
+  return base::Hash(device_string);
+}
+
 }  // namespace device