Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 12924009: Use GData WAPI's third party app authorization operation for Drive API v2. (Closed)

Created:
7 years, 9 months ago by hidehiko
Modified:
7 years, 9 months ago
Reviewers:
hashimoto, kinaba
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Use GData WAPI's third party app authorization operation for Drive API v2. Unfortunately, it is not supported to authorize third party app on Drive API v2. So, as its workaround, we use GData WAPI's authorization operation. This should work on Drive API v2, because both protocol should share the same resource id for most cases. Note that enabling Drive API v2 with a flag is still under-impelementation, so now it not ready to test it manually. It will be done when the Drive API v2 starts to work. Note that the code is not yet used, so adding the code with unit_tests should work (i.e. unless it breaks compilation nor test). BUG=179837 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M chrome/browser/chromeos/drive/drive_system_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/google_apis/drive_api_service.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/drive_api_service.cc View 3 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hidehiko
This CL is based on https://codereview.chromium.org/12880013/, and will run tryjob after it is landed. Thank ...
7 years, 9 months ago (2013-03-25 12:25:21 UTC) #1
kinaba
lgtm
7 years, 9 months ago (2013-03-25 12:27:51 UTC) #2
hashimoto
lgtm
7 years, 9 months ago (2013-03-25 13:45:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12924009/1
7 years, 9 months ago (2013-03-25 16:52:16 UTC) #4
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=23654
7 years, 9 months ago (2013-03-25 17:53:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12924009/1
7 years, 9 months ago (2013-03-25 18:35:34 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-25 21:14:11 UTC) #7
Message was sent while issue was closed.
Change committed as 190482

Powered by Google App Engine
This is Rietveld 408576698