Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 12924002: Fix AutofillDialogMenuAdapter to support showing multiple lines and icon (Closed)

Created:
7 years, 9 months ago by Yusuf
Modified:
7 years, 9 months ago
Reviewers:
Ted C, aruslan
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

Fix AutofillDialogMenuAdapter to support showing multiple lines and icon This checks whether the icon and the second line is present and makes the related layout items invisible if not present. BUG=188960 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188985

Patch Set 1 #

Total comments: 2

Patch Set 2 : Imports cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -25 lines) Patch
M chrome/android/java/res/layout/autofill_menu_item.xml View 1 chunk +28 lines, -20 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java View 1 4 chunks +21 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yusuf
7 years, 9 months ago (2013-03-18 23:37:58 UTC) #1
Ted C
lgtm w/ imports cleanup https://codereview.chromium.org/12924002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java File chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java (right): https://codereview.chromium.org/12924002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java#newcode27 chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java:27: import android.widget.RelativeLayout; looks like you ...
7 years, 9 months ago (2013-03-18 23:46:27 UTC) #2
Yusuf
https://codereview.chromium.org/12924002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java File chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java (right): https://codereview.chromium.org/12924002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java#newcode27 chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java:27: import android.widget.RelativeLayout; On 2013/03/18 23:46:27, Ted C wrote: > ...
7 years, 9 months ago (2013-03-18 23:49:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/12924002/1004
7 years, 9 months ago (2013-03-19 04:57:40 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-19 10:29:20 UTC) #5
Message was sent while issue was closed.
Change committed as 188985

Powered by Google App Engine
This is Rietveld 408576698