Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: media/filters/video_renderer_base.h

Issue 12923002: Remove unnecessary TODO comments (bug already fixed) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_FILTERS_VIDEO_RENDERER_BASE_H_ 5 #ifndef MEDIA_FILTERS_VIDEO_RENDERER_BASE_H_
6 #define MEDIA_FILTERS_VIDEO_RENDERER_BASE_H_ 6 #define MEDIA_FILTERS_VIDEO_RENDERER_BASE_H_
7 7
8 #include <deque> 8 #include <deque>
9 9
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 // frame is available for painting. 46 // frame is available for painting.
47 // 47 //
48 // |set_opaque_cb| is executed when the renderer is initialized to inform 48 // |set_opaque_cb| is executed when the renderer is initialized to inform
49 // the player whether the decoder's output will be opaque or not. 49 // the player whether the decoder's output will be opaque or not.
50 // 50 //
51 // Implementors should avoid doing any sort of heavy work in this method and 51 // Implementors should avoid doing any sort of heavy work in this method and
52 // instead post a task to a common/worker thread to handle rendering. Slowing 52 // instead post a task to a common/worker thread to handle rendering. Slowing
53 // down the video thread may result in losing synchronization with audio. 53 // down the video thread may result in losing synchronization with audio.
54 // 54 //
55 // Setting |drop_frames_| to true causes the renderer to drop expired frames. 55 // Setting |drop_frames_| to true causes the renderer to drop expired frames.
56 //
57 // TODO(scherkus): pass the VideoFrame* to this callback and remove
58 // Get/PutCurrentFrame() http://crbug.com/108435
59 VideoRendererBase(const scoped_refptr<base::MessageLoopProxy>& message_loop, 56 VideoRendererBase(const scoped_refptr<base::MessageLoopProxy>& message_loop,
60 const SetDecryptorReadyCB& set_decryptor_ready_cb, 57 const SetDecryptorReadyCB& set_decryptor_ready_cb,
61 const PaintCB& paint_cb, 58 const PaintCB& paint_cb,
62 const SetOpaqueCB& set_opaque_cb, 59 const SetOpaqueCB& set_opaque_cb,
63 bool drop_frames); 60 bool drop_frames);
64 virtual ~VideoRendererBase(); 61 virtual ~VideoRendererBase();
65 62
66 // VideoRenderer implementation. 63 // VideoRenderer implementation.
67 virtual void Initialize(const scoped_refptr<DemuxerStream>& stream, 64 virtual void Initialize(const scoped_refptr<DemuxerStream>& stream,
68 const VideoDecoderList& decoders, 65 const VideoDecoderList& decoders,
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
264 // either for calling |paint_cb_| or for dropping. Set to kNoTimestamp() 261 // either for calling |paint_cb_| or for dropping. Set to kNoTimestamp()
265 // during flushing. 262 // during flushing.
266 base::TimeDelta last_timestamp_; 263 base::TimeDelta last_timestamp_;
267 264
268 DISALLOW_COPY_AND_ASSIGN(VideoRendererBase); 265 DISALLOW_COPY_AND_ASSIGN(VideoRendererBase);
269 }; 266 };
270 267
271 } // namespace media 268 } // namespace media
272 269
273 #endif // MEDIA_FILTERS_VIDEO_RENDERER_BASE_H_ 270 #endif // MEDIA_FILTERS_VIDEO_RENDERER_BASE_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698