Issue 12922004: Fix proguard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12922004: Fix proguard (Closed)

Created:
7 years, 9 months ago by cjhopman

Modified:
7 years, 9 months ago

Reviewers:
nilesh

CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@antpy

Visibility:
Public.

More Reviews

Description

Fix proguard Proguard should only be run in Release mode (in gyp, proguard_enabled is not set based on the configuration). This is the way that we had been determining whether or not to run proguard before recent Ant refactoring. Also, proguard needs the path to the android.jar BUG=224079 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190876

Patch Set 1 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	build/android/ant/apk-obfuscate.xml	View		2 chunks	+12 lines, -1 line	0 comments	Download
	M	build/java_apk.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/12922004/2001

7 years, 9 months ago (2013-03-27 00:30:24 UTC) #3

Message was sent while issue was closed.

Change committed as 190876

Expand Messages | Collapse Messages