[Android] Enable running uiautomator tests.

[Android] Enable running uiautomator tests.

- uiautomator uses instrumentation runner for results reporting.
- Separate the concept of test jar (for progaurd consumption) from test
  apk
- clear the app before every uiautomator test

BUG=162742
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189343

[frankf, 2013-03-19 01:59:48]

For now, we don't distinguish phone/tablet. That filtering will be added in
another CL.

[craigdh, 2013-03-19 20:37:46]

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/android_c...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:1248: (test_results, _) =
am_instrument_parser.ParseAmInstrumentOutput(output)
assert len(test_results) == 1?

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:1249: return test_results[0]
add comment explaining hackery.

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/instrumen...
File build/android/pylib/instrumentation/test_runner.py (right):

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/instrumen...
build/android/pylib/instrumentation/test_runner.py:392: if 'FirstRun' in test:
fine for a first check in, but annotations are a better final solution.

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/utils/tes...
File build/android/pylib/utils/test_options_parser.py (right):

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/utils/tes...
build/android/pylib/utils/test_options_parser.py:131: def
AddCommonInstrumentationOptions(option_parser):
split these up into pylib/<test_type>/options_parser.py with a shared base
options_parser.py in base?

https://codereview.chromium.org/12921004/diff/1/build/android/run_uiautomator...
File build/android/run_uiautomator_tests.py (right):

https://codereview.chromium.org/12921004/diff/1/build/android/run_uiautomator...
build/android/run_uiautomator_tests.py:5: # found in the LICENSE file.
Seems like a lot of code duplication. Why not just support the UIAutomator flags
in run_instrumentation_tests.py?

[frankf, 2013-03-19 23:28:08]

PTAL.

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/android_c...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:1248: (test_results, _) =
am_instrument_parser.ParseAmInstrumentOutput(output)
There's an extra garbage result.

On 2013/03/19 20:37:46, craigdh wrote:
> assert len(test_results) == 1?

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:1249: return test_results[0]
On 2013/03/19 20:37:46, craigdh wrote:
> add comment explaining hackery.

Done.

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/instrumen...
File build/android/pylib/instrumentation/test_runner.py (right):

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/instrumen...
build/android/pylib/instrumentation/test_runner.py:392: if 'FirstRun' in test:
Added a TODO

On 2013/03/19 20:37:46, craigdh wrote:
> fine for a first check in, but annotations are a better final solution.

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/utils/jar...
File build/android/pylib/utils/jar_helper.py (right):

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/utils/jar...
build/android/pylib/utils/jar_helper.py:167: adb.PushIfNeeded(self._jar_path,
constants.TEST_EXECUTABLE_DIR)
remove this

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/utils/tes...
File build/android/pylib/utils/test_options_parser.py (right):

https://codereview.chromium.org/12921004/diff/1/build/android/pylib/utils/tes...
build/android/pylib/utils/test_options_parser.py:131: def
AddCommonInstrumentationOptions(option_parser):
Yea, we need to rethink the option parsers in general. Let's do this in a future
CL. 

On 2013/03/19 20:37:46, craigdh wrote:
> split these up into pylib/<test_type>/options_parser.py with a shared base
> options_parser.py in base?

https://codereview.chromium.org/12921004/diff/1/build/android/run_uiautomator...
File build/android/run_uiautomator_tests.py (right):

https://codereview.chromium.org/12921004/diff/1/build/android/run_uiautomator...
build/android/run_uiautomator_tests.py:5: # found in the LICENSE file.
Discussed offline. It's more clear to have separate executables.

On 2013/03/19 20:37:46, craigdh wrote:
> Seems like a lot of code duplication. Why not just support the UIAutomator
flags
> in run_instrumentation_tests.py?

[craigdh, 2013-03-20 00:17:07]

On 2013/03/19 23:28:08, frankf wrote:
> PTAL.
> 
>
https://codereview.chromium.org/12921004/diff/1/build/android/pylib/android_c...
> File build/android/pylib/android_commands.py (right):
> 
>
https://codereview.chromium.org/12921004/diff/1/build/android/pylib/android_c...
> build/android/pylib/android_commands.py:1248: (test_results, _) =
> am_instrument_parser.ParseAmInstrumentOutput(output)
> There's an extra garbage result.
> 
> On 2013/03/19 20:37:46, craigdh wrote:
> > assert len(test_results) == 1?
> 
>
https://codereview.chromium.org/12921004/diff/1/build/android/pylib/android_c...
> build/android/pylib/android_commands.py:1249: return test_results[0]
> On 2013/03/19 20:37:46, craigdh wrote:
> > add comment explaining hackery.
> 
> Done.
> 
>
https://codereview.chromium.org/12921004/diff/1/build/android/pylib/instrumen...
> File build/android/pylib/instrumentation/test_runner.py (right):
> 
>
https://codereview.chromium.org/12921004/diff/1/build/android/pylib/instrumen...
> build/android/pylib/instrumentation/test_runner.py:392: if 'FirstRun' in test:
> Added a TODO
> 
> On 2013/03/19 20:37:46, craigdh wrote:
> > fine for a first check in, but annotations are a better final solution.
> 
>
https://codereview.chromium.org/12921004/diff/1/build/android/pylib/utils/jar...
> File build/android/pylib/utils/jar_helper.py (right):
> 
>
https://codereview.chromium.org/12921004/diff/1/build/android/pylib/utils/jar...
> build/android/pylib/utils/jar_helper.py:167: adb.PushIfNeeded(self._jar_path,
> constants.TEST_EXECUTABLE_DIR)
> remove this
> 
>
https://codereview.chromium.org/12921004/diff/1/build/android/pylib/utils/tes...
> File build/android/pylib/utils/test_options_parser.py (right):
> 
>
https://codereview.chromium.org/12921004/diff/1/build/android/pylib/utils/tes...
> build/android/pylib/utils/test_options_parser.py:131: def
> AddCommonInstrumentationOptions(option_parser):
> Yea, we need to rethink the option parsers in general. Let's do this in a
future
> CL. 
> 
> On 2013/03/19 20:37:46, craigdh wrote:
> > split these up into pylib/<test_type>/options_parser.py with a shared base
> > options_parser.py in base?
> 
>
https://codereview.chromium.org/12921004/diff/1/build/android/run_uiautomator...
> File build/android/run_uiautomator_tests.py (right):
> 
>
https://codereview.chromium.org/12921004/diff/1/build/android/run_uiautomator...
> build/android/run_uiautomator_tests.py:5: # found in the LICENSE file.
> Discussed offline. It's more clear to have separate executables.
> 
> On 2013/03/19 20:37:46, craigdh wrote:
> > Seems like a lot of code duplication. Why not just support the UIAutomator
> flags
> > in run_instrumentation_tests.py?

lgtm, filed http://crbug.com/222275 for splitting up test_options_parser.py.

[commit-bot: I haz the power, 2013-03-20 18:04:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/frankf@chromium.org/12921004/10001

[commit-bot: I haz the power, 2013-03-20 18:06:55]

Change committed as 189343