Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 12921002: Add dbus_unittests to chromium_builder_tests target. (Closed)

Created:
7 years, 9 months ago by Sam Clegg
Modified:
7 years, 9 months ago
Reviewers:
iannucci
CC:
chromium-reviews
Visibility:
Public.

Description

Add dbus_unittests to chromium_builder_tests target. Not having this binary is causing the ARM FYI tester to fail. BUG=218576 TEST=ninja chromium_builder_tests && check for dbus_unittests being built. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188949

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sam Clegg
7 years, 9 months ago (2013-03-18 19:58:15 UTC) #1
iannucci
This lgtm... I'm a little uncomfortable that we don't know why this is working elsewhere ...
7 years, 9 months ago (2013-03-18 20:02:32 UTC) #2
Sam Clegg
On 2013/03/18 20:02:32, iannucci wrote: > This lgtm... I'm a little uncomfortable that we don't ...
7 years, 9 months ago (2013-03-18 20:35:35 UTC) #3
iannucci
On 2013/03/18 20:35:35, Sam Clegg wrote: > On 2013/03/18 20:02:32, iannucci wrote: > > This ...
7 years, 9 months ago (2013-03-18 21:01:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbc@chromium.org/12921002/1
7 years, 9 months ago (2013-03-18 23:30:00 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-19 03:52:41 UTC) #6
Message was sent while issue was closed.
Change committed as 188949

Powered by Google App Engine
This is Rietveld 408576698