Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3022)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/signin/signin_error_notifier_ash.cc

Issue 1292003004: Elide origins displayed on web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Style nit Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/search/hotword_service.cc ('k') | chrome/browser/sync/sync_error_notifier_ash.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_error_notifier_ash.cc
diff --git a/chrome/browser/signin/signin_error_notifier_ash.cc b/chrome/browser/signin/signin_error_notifier_ash.cc
index d3045606c04af051d9834dcbb79400d2a3c26a02..25c4d06f72693c039aef9d53b836748c9b2a7b2f 100644
--- a/chrome/browser/signin/signin_error_notifier_ash.cc
+++ b/chrome/browser/signin/signin_error_notifier_ash.cc
@@ -179,16 +179,12 @@ void SigninErrorNotifier::OnErrorChanged() {
Notification notification(
message_center::NOTIFICATION_TYPE_SIMPLE,
- GURL(notification_id_),
l10n_util::GetStringUTF16(IDS_SIGNIN_ERROR_BUBBLE_VIEW_TITLE),
- GetMessageBody(),
- ui::ResourceBundle::GetSharedInstance().GetImageNamed(
- IDR_NOTIFICATION_ALERT),
+ GetMessageBody(), ui::ResourceBundle::GetSharedInstance().GetImageNamed(
+ IDR_NOTIFICATION_ALERT),
notifier_id,
base::string16(), // display_source
- notification_id_,
- data,
- delegate);
+ GURL(notification_id_), notification_id_, data, delegate);
// Update or add the notification.
if (notification_ui_manager->FindById(
« no previous file with comments | « chrome/browser/search/hotword_service.cc ('k') | chrome/browser/sync/sync_error_notifier_ash.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698