chrome/browser/chromeos/printer_detector/printer_detector.cc - Issue 1292003004: Elide origins displayed on web notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/printer_detector/printer_detector.cc

Issue 1292003004: Elide origins displayed on web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Style nit Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/power/peripheral_battery_observer.cc ('k') | chrome/browser/download/notification/download_group_notification.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/printer_detector/printer_detector.cc

diff --git a/chrome/browser/chromeos/printer_detector/printer_detector.cc b/chrome/browser/chromeos/printer_detector/printer_detector.cc

index bcafab036a4c9d2d20e4a18e6abd808614a44593..e37f48eeec85eb498b81164a6474855ce540f127 100644

--- a/chrome/browser/chromeos/printer_detector/printer_detector.cc

+++ b/chrome/browser/chromeos/printer_detector/printer_detector.cc

@@ -211,14 +211,14 @@ void ShowPrinterPluggedNotification(

PRINTER_SERVICE_EVENT_MAX);

notification.reset(new Notification(

message_center::NOTIFICATION_TYPE_SIMPLE,

- GURL(kPrinterProviderFoundNotificationID),

GetNotificationTitle(device->vendor_id(), device->product_id()),

l10n_util::GetStringUTF16(

IDS_PRINTER_DETECTED_NOTIFICATION_PRINT_APP_FOUND_BODY),

bundle.GetImageNamed(IDR_PRINTER_NOTIFICATION),

message_center::NotifierId(message_center::NotifierId::SYSTEM_COMPONENT,

kPrinterProviderFoundNotificationID),

- base::string16(), GetNotificationTag(kVendorIdStr, kProductIdStr),

+ base::string16(), GURL(kPrinterProviderFoundNotificationID),

+ GetNotificationTag(kVendorIdStr, kProductIdStr),

message_center::RichNotificationData(),

new PrinterProviderExistsNotificationDelegate(kVendorIdStr,

kProductIdStr)));

@@ -230,17 +230,17 @@ void ShowPrinterPluggedNotification(

options.clickable = true;

notification.reset(new Notification(

message_center::NOTIFICATION_TYPE_SIMPLE,

- GURL(kNoPrinterProviderNotificationID),

GetNotificationTitle(device->vendor_id(), device->product_id()),

l10n_util::GetStringUTF16(

IDS_PRINTER_DETECTED_NOTIFICATION_NO_PRINT_APP_BODY),

bundle.GetImageNamed(IDR_PRINTER_NOTIFICATION),

message_center::NotifierId(message_center::NotifierId::SYSTEM_COMPONENT,

kNoPrinterProviderNotificationID),

- base::string16(), GetNotificationTag(kVendorIdStr, kProductIdStr),

- options, new SearchPrinterAppNotificationDelegate(

- profile, device->vendor_id(), kVendorIdStr,

- device->product_id(), kProductIdStr)));

+ base::string16(), GURL(kNoPrinterProviderNotificationID),

+ GetNotificationTag(kVendorIdStr, kProductIdStr), options,

+ new SearchPrinterAppNotificationDelegate(

+ profile, device->vendor_id(), kVendorIdStr, device->product_id(),

+ kProductIdStr)));

}

notification->SetSystemPriority();