chrome/browser/chromeos/net/network_portal_notification_controller.cc - Issue 1292003004: Elide origins displayed on web notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_notification_controller.cc

Issue 1292003004: Elide origins displayed on web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Style nit Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/first_run/drive_first_run_controller.cc ('k') | chrome/browser/chromeos/policy/consumer_management_notifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/network_portal_notification_controller.cc

diff --git a/chrome/browser/chromeos/net/network_portal_notification_controller.cc b/chrome/browser/chromeos/net/network_portal_notification_controller.cc

index be0ba83f621a2d4491530b7dc1a478c2362b8c26..e9490adbc1b28bcfb5734fc64e517b0a1d8ddda6 100644

--- a/chrome/browser/chromeos/net/network_portal_notification_controller.cc

+++ b/chrome/browser/chromeos/net/network_portal_notification_controller.cc

@@ -337,7 +337,7 @@ NetworkPortalNotificationController::CreateDefaultCaptivePortalNotification(

is_wifi ? IDS_PORTAL_DETECTION_NOTIFICATION_MESSAGE_WIFI

: IDS_PORTAL_DETECTION_NOTIFICATION_MESSAGE_WIRED,

base::UTF8ToUTF16(network->name())),

- icon, base::string16(), notifier_id, data, delegate.get()));

+ icon, base::string16(), GURL(), notifier_id, data, delegate.get()));

notification->SetSystemPriority();

return notification.Pass();

}

@@ -386,7 +386,7 @@ scoped_ptr<message_center::Notification> NetworkPortalNotificationController::

scoped_ptr<Notification> notification(new Notification(

message_center::NOTIFICATION_TYPE_SIMPLE, kNotificationId,

l10n_util::GetStringUTF16(IDS_PORTAL_DETECTION_NOTIFICATION_TITLE_WIFI),

- notificationText, icon, base::string16() /* display_source */,

+ notificationText, icon, base::string16() /* display_source */, GURL(),

notifier_id, data, delegate.get()));

notification->SetSystemPriority();

return notification.Pass();