chrome/browser/download/notification/download_group_notification.cc - Issue 1292003004: Elide origins displayed on web notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/notification/download_group_notification.cc

Issue 1292003004: Elide origins displayed on web notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove the use_origin flag in Notification do everything in NotificationView Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/printer_detector/printer_detector.cc ('k') | chrome/browser/download/notification/download_item_notification.cc » ('j') | ui/message_center/cocoa/notification_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/notification/download_group_notification.cc

diff --git a/chrome/browser/download/notification/download_group_notification.cc b/chrome/browser/download/notification/download_group_notification.cc

index fef4c6c856c8979e01b526709874a172d0d73915..4dfe1053ab22eb3a761b7d3cc9b9b2746a58d9d1 100644

--- a/chrome/browser/download/notification/download_group_notification.cc

+++ b/chrome/browser/download/notification/download_group_notification.cc

@@ -103,14 +103,14 @@ DownloadGroupNotification::DownloadGroupNotification(

// by UpdateNotificationData() below.

notification_.reset(new Notification(

message_center::NOTIFICATION_TYPE_MULTIPLE,

- GURL(kDownloadNotificationOrigin), // origin_url

- base::string16(), // title

- base::string16(), // body

+ base::string16(), // title

+ base::string16(), // body

bundle.GetImageNamed(IDR_DOWNLOAD_NOTIFICATION_DOWNLOADING),

message_center::NotifierId(message_center::NotifierId::SYSTEM_COMPONENT,

kDownloadNotificationNotifierId),

- base::string16(), // display_source

- "GROUP", // tag

+ base::string16(), // display_source

+ GURL(kDownloadNotificationOrigin), // origin_url

+ "GROUP", // tag

data, watcher()));

notification_->SetSystemPriority();