Adds support for CoreAudioUtil::IsChannelLayoutSupported()

Adds support for CoreAudioUtil::IsChannelLayoutSupported()

BUG=177872
TEST=media_unittests.exe --gtest_filter=Core*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191827

[DaleCurtis, 2013-03-27 17:30:18]

https://codereview.chromium.org/12918026/diff/1/media/audio/win/core_audio_ut...
File media/audio/win/core_audio_util_win.cc (right):

https://codereview.chromium.org/12918026/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:73: case CHANNEL_LAYOUT_NONE:
These top two should be UNSUPPORTED.

https://codereview.chromium.org/12918026/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:105: return CHANNEL_LAYOUT_UNSUPPORTED;
I'm surprised this ChannelLayout returns correctly as a ChannelConfig?

https://codereview.chromium.org/12918026/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:470: format.dwChannelMask = new_config;
Bail early if new_config == unsupported? Should probably be the first thing
checked before any allocations.

https://codereview.chromium.org/12918026/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:481: return
CoreAudioUtil::IsFormatSupported(client, AUDCLNT_SHAREMODE_SHARED,
align &format or wrap the whole line.

https://codereview.chromium.org/12918026/diff/1/media/audio/win/core_audio_ut...
File media/audio/win/core_audio_util_win_unittest.cc (right):

https://codereview.chromium.org/12918026/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win_unittest.cc:257:
EXPECT_FALSE(CoreAudioUtil::IsChannelLayoutSupported(
Heh. I'll take a private build back to my place tonight and see what's up.

[henrika (OOO until Aug 14), 2013-03-28 09:15:04]

Thanks Dale, PTAL.

I will not land until we have tested on more hardware.

https://codereview.chromium.org/12918026/diff/1/media/audio/win/core_audio_ut...
File media/audio/win/core_audio_util_win.cc (right):

https://codereview.chromium.org/12918026/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:73: case CHANNEL_LAYOUT_NONE:
On 2013/03/27 17:30:18, DaleCurtis wrote:
> These top two should be UNSUPPORTED.

Defined KSAUDIO_SPEAKER_UNSUPPORTED locally.

https://codereview.chromium.org/12918026/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:105: return CHANNEL_LAYOUT_UNSUPPORTED;
fixed.

https://codereview.chromium.org/12918026/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:470: format.dwChannelMask = new_config;
On 2013/03/27 17:30:18, DaleCurtis wrote:
> Bail early if new_config == unsupported? Should probably be the first thing
> checked before any allocations.

Done.

https://codereview.chromium.org/12918026/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win.cc:481: return
CoreAudioUtil::IsFormatSupported(client, AUDCLNT_SHAREMODE_SHARED,
On 2013/03/27 17:30:18, DaleCurtis wrote:
> align &format or wrap the whole line.

Done.

https://codereview.chromium.org/12918026/diff/1/media/audio/win/core_audio_ut...
File media/audio/win/core_audio_util_win_unittest.cc (right):

https://codereview.chromium.org/12918026/diff/1/media/audio/win/core_audio_ut...
media/audio/win/core_audio_util_win_unittest.cc:257:
EXPECT_FALSE(CoreAudioUtil::IsChannelLayoutSupported(
Thanks. I will check when I receive my device as well.

[DaleCurtis, 2013-03-28 17:51:13]

Actually this didn't work on my local system.  Doing some digging I found it
worked before because the app I tested was opening the audio device in exclusive
mode.

I'll link my test build to our troubled user and see if it resolves his issue.

[henrika (OOO until Aug 14), 2013-03-28 18:01:56]

Yes, with exclusive mode only the sky is the limit but I did not consider it as
a default implementation. I have added initial support for exclusive mode but it
has not been tested carefully for all cases since I added the CoreAudioUtil. I
could perhaps do more work for exclusive mode and advice users to run with a
flag.

[DaleCurtis, 2013-04-01 20:43:50]

lgtm % nit. Should help a few users.

https://codereview.chromium.org/12918026/diff/4001/media/audio/win/core_audio...
File media/audio/win/core_audio_util_win.cc (right):

https://codereview.chromium.org/12918026/diff/4001/media/audio/win/core_audio...
media/audio/win/core_audio_util_win.cc:23: #define KSAUDIO_SPEAKER_UNSUPPORTED 0
enum { KSAUDIO_SPEAKER_UNSUPPORTED = 0 } instead ?

[henrika (OOO until Aug 14), 2013-04-02 10:54:05]

https://codereview.chromium.org/12918026/diff/4001/media/audio/win/core_audio...
File media/audio/win/core_audio_util_win.cc (right):

https://codereview.chromium.org/12918026/diff/4001/media/audio/win/core_audio...
media/audio/win/core_audio_util_win.cc:23: #define KSAUDIO_SPEAKER_UNSUPPORTED 0
On 2013/04/01 20:43:50, DaleCurtis wrote:
> enum { KSAUDIO_SPEAKER_UNSUPPORTED = 0 } instead ?

Done.

[commit-bot: I haz the power, 2013-04-02 10:56:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/henrika@chromium.org/12918026/10001

[commit-bot: I haz the power, 2013-04-02 13:19:29]

Change committed as 191827

[henrika (OOO until Aug 14), 2013-04-03 07:50:32]

This patch was reverted since it broke an XP bot. 

New version can be found at https://codereview.chromium.org/13515005