Removing arguments from the activity log

Due to privacy concerns about the data contained in API call arguments, we no longer will log the arguments unless:

(1) The API call has been whitelisted because we need the arguments and there is no explicit privacy issue w/r/t the arguments of that API call, or

(2) The browser's activity log testing flag has been set.

I set up an API_action whitelist with a few preliminary ones. We'll probably need to expand it and add similar whitelists for events.

For now, this does not affect DOM API calls because we will be taking a whitelisting approach to DOM API calls to begin with.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189134

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189312

[felt, 2013-03-18 22:45:04]

Hi Matt, can you please review this?

Ulfar, Michael, and Ankur, you're all cc'ed because this will affect what you
see in tests. You may want to set the flag to log all arguments for your own
testing.

Michael: FYI, depending on what happens with your WebRequest changes, we may
want to add WebRequest to the whitelist, special-case some of its arguments, or
something else.

[Matt Perry, 2013-03-19 01:25:06]

lgtm

https://codereview.chromium.org/12918020/diff/4002/chrome/browser/extensions/...
File chrome/browser/extensions/activity_log.cc (right):

https://codereview.chromium.org/12918020/diff/4002/chrome/browser/extensions/...
chrome/browser/extensions/activity_log.cc:247: if (log_arguments_ ||
nit: more compact:
 bool log_args = ...;
 LogAPIActionInternal(extension, api_call,
    log_args ? args : new ListValue(),
    extra, APIAction::CALL);

https://codereview.chromium.org/12918020/diff/4002/chrome/browser/extensions/...
File chrome/browser/extensions/activity_log_unittest.cc (right):

https://codereview.chromium.org/12918020/diff/4002/chrome/browser/extensions/...
chrome/browser/extensions/activity_log_unittest.cc:160: extension->id(),
indent

[commit-bot: I haz the power, 2013-03-19 02:09:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/12918020/18001

[commit-bot: I haz the power, 2013-03-19 02:56:21]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-03-19 17:19:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/12918020/28001

[commit-bot: I haz the power, 2013-03-19 22:23:57]

Change committed as 189134

[commit-bot: I haz the power, 2013-03-20 04:47:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/12918020/48001

[commit-bot: I haz the power, 2013-03-20 07:46:17]

Retried try job too often on win_rel for step(s) net_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-03-20 14:33:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/felt@chromium.org/12918020/48001

[commit-bot: I haz the power, 2013-03-20 16:49:50]

Change committed as 189312