Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 12917023: Bluetooth: Disable "IsConnectable" property for ChromeOS implementation. (Closed)

Created:
7 years, 9 months ago by deymo
Modified:
7 years, 9 months ago
Reviewers:
keybuk
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Bluetooth: Disable "IsConnectable" property for ChromeOS implementation. The IsConnectable property tells if a given device can be re-connected later once paired. If it is false, the device is not supposed to respond to a connection attempt from the host, and since we know it, we don't show the connect button for this kind of devices. This fix rollbacks the IsConnectable implementation in ChromeOS and default its value to true because some mice don't support pairing and should be possible to connect to them regardless the value of this property. BUG=chromium:220553 TEST=Pair to Microsoft mouse 5000, disconnect and try to connect again. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190559

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M device/bluetooth/bluetooth_device_chromeos.h View 1 chunk +0 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_device_chromeos.cc View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
deymo
Disbling IsConnectable(). It breaks the Microsoft 5000 mouse compatibility, and that's a regression. Heading the ...
7 years, 9 months ago (2013-03-22 21:43:24 UTC) #1
keybuk
Is this a revert of a previous patch, or is this a new patch?
7 years, 9 months ago (2013-03-25 15:58:12 UTC) #2
deymo
On 2013/03/25 15:58:12, keybuk wrote: > Is this a revert of a previous patch, or ...
7 years, 9 months ago (2013-03-25 16:58:04 UTC) #3
keybuk
What are the effects of the partial revert? The connectable property will still exist - ...
7 years, 9 months ago (2013-03-25 17:13:38 UTC) #4
deymo
On 2013/03/25 17:13:38, keybuk wrote: > What are the effects of the partial revert? > ...
7 years, 9 months ago (2013-03-25 17:50:57 UTC) #5
keybuk
Ok
7 years, 9 months ago (2013-03-25 17:52:35 UTC) #6
keybuk
lgtm after adjusting the commit message to include the details discussed above
7 years, 9 months ago (2013-03-25 17:53:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deymo@chromium.org/12917023/1
7 years, 9 months ago (2013-03-25 18:30:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deymo@chromium.org/12917023/1
7 years, 9 months ago (2013-03-26 05:56:03 UTC) #9
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 06:06:17 UTC) #10
Message was sent while issue was closed.
Change committed as 190559

Powered by Google App Engine
This is Rietveld 408576698