Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 12916011: [Telemetry] Compress textual resources in memory cache http server. (Closed)

Created:
7 years, 9 months ago by tonyg
Modified:
7 years, 9 months ago
Reviewers:
dtu, nduca
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Compress textual resources in memory cache http server. This reduces intl1 memory usages by ~10M or 22%. This has two benefits: 1. The memory usage by the http server seems to be causing intl1 to fail on the win perf bots. 2. Decompressing textual resources makes the page loads more realistic. BUG=223543 TEST=intl1 page cycler on windows NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190544

Patch Set 1 #

Patch Set 2 : Move str() to response time #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M tools/telemetry/telemetry/core/memory_cache_http_server.py View 1 3 chunks +13 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tonyg
7 years, 9 months ago (2013-03-26 01:04:26 UTC) #1
dtu
lgtm. Why just text?
7 years, 9 months ago (2013-03-26 01:45:07 UTC) #2
tonyg
On 2013/03/26 01:45:07, Dave Tu wrote: > lgtm. Why just text? Typically on the web, ...
7 years, 9 months ago (2013-03-26 02:08:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/12916011/2001
7 years, 9 months ago (2013-03-26 02:09:49 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 02:18:41 UTC) #5
Message was sent while issue was closed.
Change committed as 190544

Powered by Google App Engine
This is Rietveld 408576698