Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 12916010: SyncFS: -1 GDataErrorCode should be handled gracefully (Closed)

Created:
7 years, 9 months ago by kinuko
Modified:
7 years, 9 months ago
Reviewers:
calvinlo, nhiroki, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

SyncFS: -1 GDataErrorCode should be handled gracefully GData service code seems to occasionally return -1 when network is unavailable. BUG=223042 TEST=manual NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190536

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/sync_file_system/drive_file_sync_util.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kinuko
ptl
7 years, 9 months ago (2013-03-26 00:34:37 UTC) #1
nhiroki
LGTM! Thanks for working on this.
7 years, 9 months ago (2013-03-26 00:43:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/12916010/1
7 years, 9 months ago (2013-03-26 00:47:50 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-26 01:01:12 UTC) #4
Message was sent while issue was closed.
Change committed as 190536

Powered by Google App Engine
This is Rietveld 408576698