build/android/strip_library_for_apk.py - Issue 12913028: Output better error messages during build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/strip_library_for_apk.py

Issue 12913028: Output better error messages during build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/strip_library_for_apk.py

diff --git a/build/android/strip_library_for_apk.py b/build/android/strip_library_for_apk.py

index f0cd08713a82b566776b012a6f10b68601205f60..9b526484f3e2bc14dd8bc592c13b39a214c81faa 100755

--- a/build/android/strip_library_for_apk.py

+++ b/build/android/strip_library_for_apk.py

@@ -6,7 +6,6 @@

import optparse

import os

-import subprocess

import sys

from pylib import build_utils

@@ -16,7 +15,7 @@ def StripLibrary(android_strip, android_strip_args, library_path, output_path):

strip_cmd = ([android_strip] +

android_strip_args +

['-o', output_path, library_path])

- subprocess.check_call(strip_cmd)

+ build_utils.CheckCallDie(strip_cmd)

def main(argv):

« no previous file with comments | « build/android/pylib/build_utils.py ('k') | no next file » | no next file with comments »