Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: cc/output/delegating_renderer_unittest.cc

Issue 12912010: cc: Convert non-const reference arguments to pointers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix ui/compositor Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cc/output/delegating_renderer.cc ('k') | cc/output/direct_renderer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/output/delegating_renderer.h" 5 #include "cc/output/delegating_renderer.h"
6 6
7 #include "cc/test/fake_output_surface.h" 7 #include "cc/test/fake_output_surface.h"
8 #include "cc/test/layer_tree_test.h" 8 #include "cc/test/layer_tree_test.h"
9 #include "cc/test/render_pass_test_common.h" 9 #include "cc/test/render_pass_test_common.h"
10 #include "cc/test/render_pass_test_utils.h" 10 #include "cc/test/render_pass_test_utils.h"
(...skipping 30 matching lines...) Expand all
41 PostSetNeedsCommitToMainThread(); 41 PostSetNeedsCommitToMainThread();
42 } 42 }
43 43
44 virtual void AfterTest() OVERRIDE {} 44 virtual void AfterTest() OVERRIDE {}
45 45
46 virtual bool PrepareToDrawOnThread( 46 virtual bool PrepareToDrawOnThread(
47 LayerTreeHostImpl*, LayerTreeHostImpl::FrameData* frame, bool result) 47 LayerTreeHostImpl*, LayerTreeHostImpl::FrameData* frame, bool result)
48 OVERRIDE { 48 OVERRIDE {
49 EXPECT_EQ(0u, output_surface_->num_sent_frames()); 49 EXPECT_EQ(0u, output_surface_->num_sent_frames());
50 50
51 CompositorFrame& last_frame = output_surface_->last_sent_frame(); 51 const CompositorFrame& last_frame = output_surface_->last_sent_frame();
52 EXPECT_FALSE(last_frame.delegated_frame_data); 52 EXPECT_FALSE(last_frame.delegated_frame_data);
53 EXPECT_FALSE(last_frame.gl_frame_data); 53 EXPECT_FALSE(last_frame.gl_frame_data);
54 EXPECT_EQ(0.f, last_frame.metadata.min_page_scale_factor); 54 EXPECT_EQ(0.f, last_frame.metadata.min_page_scale_factor);
55 EXPECT_EQ(0.f, last_frame.metadata.max_page_scale_factor); 55 EXPECT_EQ(0.f, last_frame.metadata.max_page_scale_factor);
56 return true; 56 return true;
57 } 57 }
58 58
59 virtual void DrawLayersOnThread(LayerTreeHostImpl* host_impl) OVERRIDE { 59 virtual void DrawLayersOnThread(LayerTreeHostImpl* host_impl) OVERRIDE {
60 EXPECT_EQ(1u, output_surface_->num_sent_frames()); 60 EXPECT_EQ(1u, output_surface_->num_sent_frames());
61 61
62 CompositorFrame& last_frame = output_surface_->last_sent_frame(); 62 const CompositorFrame& last_frame = output_surface_->last_sent_frame();
63 DelegatedFrameData* last_frame_data = last_frame.delegated_frame_data.get(); 63 DelegatedFrameData* last_frame_data = last_frame.delegated_frame_data.get();
64 ASSERT_TRUE(last_frame.delegated_frame_data); 64 ASSERT_TRUE(last_frame.delegated_frame_data);
65 EXPECT_FALSE(last_frame.gl_frame_data); 65 EXPECT_FALSE(last_frame.gl_frame_data);
66 EXPECT_EQ( 66 EXPECT_EQ(
67 gfx::Rect(host_impl->device_viewport_size()).ToString(), 67 gfx::Rect(host_impl->device_viewport_size()).ToString(),
68 last_frame_data->render_pass_list.back()->output_rect.ToString()); 68 last_frame_data->render_pass_list.back()->output_rect.ToString());
69 EXPECT_EQ(0.5f, last_frame.metadata.min_page_scale_factor); 69 EXPECT_EQ(0.5f, last_frame.metadata.min_page_scale_factor);
70 EXPECT_EQ(4.f, last_frame.metadata.max_page_scale_factor); 70 EXPECT_EQ(4.f, last_frame.metadata.max_page_scale_factor);
71 71
72 EXPECT_EQ( 72 EXPECT_EQ(
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 gfx::Rect(3, 3, 10, 10), 109 gfx::Rect(3, 3, 10, 10),
110 gfx::Transform()); 110 gfx::Transform());
111 pass->AppendOneOfEveryQuadType( 111 pass->AppendOneOfEveryQuadType(
112 host_impl->resource_provider(), child_pass->id); 112 host_impl->resource_provider(), child_pass->id);
113 return true; 113 return true;
114 } 114 }
115 115
116 virtual void DrawLayersOnThread(LayerTreeHostImpl* host_impl) OVERRIDE { 116 virtual void DrawLayersOnThread(LayerTreeHostImpl* host_impl) OVERRIDE {
117 EXPECT_EQ(1u, output_surface_->num_sent_frames()); 117 EXPECT_EQ(1u, output_surface_->num_sent_frames());
118 118
119 CompositorFrame& last_frame = output_surface_->last_sent_frame(); 119 const CompositorFrame& last_frame = output_surface_->last_sent_frame();
120 ASSERT_TRUE(last_frame.delegated_frame_data); 120 ASSERT_TRUE(last_frame.delegated_frame_data);
121 121
122 EXPECT_EQ(2u, last_frame.delegated_frame_data->render_pass_list.size()); 122 EXPECT_EQ(2u, last_frame.delegated_frame_data->render_pass_list.size());
123 // Each render pass has 7 resources in it. And the root render pass has a 123 // Each render pass has 7 resources in it. And the root render pass has a
124 // mask resource used when drawing the child render pass. The number 7 may 124 // mask resource used when drawing the child render pass. The number 7 may
125 // change if AppendOneOfEveryQuadType is updated, and the value here should 125 // change if AppendOneOfEveryQuadType is updated, and the value here should
126 // be updated accordingly. 126 // be updated accordingly.
127 EXPECT_EQ( 127 EXPECT_EQ(
128 15u, last_frame.delegated_frame_data->resource_list.size()); 128 15u, last_frame.delegated_frame_data->resource_list.size());
129 129
130 EndTest(); 130 EndTest();
131 } 131 }
132 }; 132 };
133 133
134 SINGLE_AND_MULTI_THREAD_TEST_F(DelegatingRendererTestResources) 134 SINGLE_AND_MULTI_THREAD_TEST_F(DelegatingRendererTestResources)
135 135
136 } // namespace cc 136 } // namespace cc
OLDNEW
« no previous file with comments | « cc/output/delegating_renderer.cc ('k') | cc/output/direct_renderer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698