Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: content/browser/devtools/devtools_http_handler_impl.cc

Issue 12906011: Detect debugging target crash. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/devtools/devtools_http_handler_impl.h ('k') | content/browser/devtools/devtools_protocol.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/devtools_http_handler_impl.cc
diff --git a/content/browser/devtools/devtools_http_handler_impl.cc b/content/browser/devtools/devtools_http_handler_impl.cc
index 6a995a6a9ae5df481146300e8480a35f96018723..cc436820d074254aa63b14b134f4a14af3e5e749 100644
--- a/content/browser/devtools/devtools_http_handler_impl.cc
+++ b/content/browser/devtools/devtools_http_handler_impl.cc
@@ -278,24 +278,6 @@ static std::string GetMimeType(const std::string& filename) {
return "text/plain";
}
-void DevToolsHttpHandlerImpl::Observe(int type,
- const NotificationSource& source,
- const NotificationDetails& details) {
- RenderProcessHost* process = Source<RenderProcessHost>(source).ptr();
- DevToolsManager* manager = DevToolsManager::GetInstance();
- for (ConnectionToClientHostMap::iterator it =
- connection_to_client_host_ui_.begin();
- it != connection_to_client_host_ui_.end(); ++it) {
- DevToolsAgentHost* agent = manager->GetDevToolsAgentHostFor(it->second);
- if (!agent)
- continue;
- RenderViewHost* rvh = agent->GetRenderViewHost();
- // TODO(kaznacheev) Handle process termination for shared workers.
- if (rvh && rvh->GetProcess() == process)
- it->second->InspectedContentsClosing();
- }
-}
-
void DevToolsHttpHandlerImpl::OnHttpRequest(
int connection_id,
const net::HttpServerRequestInfo& info) {
@@ -693,11 +675,6 @@ DevToolsHttpHandlerImpl::DevToolsHttpHandlerImpl(
default_binding_.reset(new DevToolsDefaultBindingHandler);
binding_ = default_binding_.get();
- registrar_.Add(this, NOTIFICATION_RENDERER_PROCESS_TERMINATED,
- NotificationService::AllBrowserContextsAndSources());
- registrar_.Add(this, NOTIFICATION_RENDERER_PROCESS_CLOSED,
- NotificationService::AllBrowserContextsAndSources());
-
// Balanced in ResetHandlerThreadAndRelease().
AddRef();
}
« no previous file with comments | « content/browser/devtools/devtools_http_handler_impl.h ('k') | content/browser/devtools/devtools_protocol.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698