Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 12900005: [Telemetry] Fix histogram naming. (Closed)

Created:
7 years, 9 months ago by tonyg
Modified:
7 years, 9 months ago
Reviewers:
marja
CC:
chromium-reviews, chrome-speed-team+watch_google.com, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, telemetry+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Telemetry] Fix histogram naming. trace_tags should show up on the trace names but not the chart names. Previously we'd output: HISTOGRAM V8.MemoryHeapSampleTotalUsed_foo: V8.MemoryHeapSampleTotalUsed_foo= Now we output: HISTOGRAM V8.MemoryHeapSampleTotalUsed: V8.MemoryHeapSampleTotalUsed_foo= This prevents an explosion of charts as seen on: http://build.chromium.org/f/chromium/perf/linux-release/moz/report.html?history=150&rev=-1&graph=V8.MemoryExternalFragmentationTotal_extcs1_0.5 BUG=196411 TEST=tools/perf/run_multipage_benchmarks --browser=system page_cycler tools/perf/page_sets/page_cycler/moz.json --output-trace-tag=_foo NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189022

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M build/android/pylib/perf_tests_helper.py View 1 chunk +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/page/page_benchmark_results.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tonyg
ptal
7 years, 9 months ago (2013-03-19 00:56:33 UTC) #1
marja
So this would put lines for different pages into the same graph? I'm not sure ...
7 years, 9 months ago (2013-03-19 01:00:11 UTC) #2
tonyg
On 2013/03/19 01:00:11, marja wrote: > So this would put lines for different pages into ...
7 years, 9 months ago (2013-03-19 01:04:58 UTC) #3
marja
Ah, k. lgtm.
7 years, 9 months ago (2013-03-19 03:56:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/12900005/2001
7 years, 9 months ago (2013-03-19 15:36:01 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-19 15:36:40 UTC) #6
Message was sent while issue was closed.
Change committed as 189022

Powered by Google App Engine
This is Rietveld 408576698