Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1649)

Unified Diff: components/autofill/browser/wallet/wallet_items.cc

Issue 12893007: Implementing VERIFY_CVV required action. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/browser/wallet/wallet_items.cc
diff --git a/components/autofill/browser/wallet/wallet_items.cc b/components/autofill/browser/wallet/wallet_items.cc
index 19f2daa6b5f42be2d0b80e38bc514fe76243accd..716dd9a74b686998e2062513c247347de18e5048 100644
--- a/components/autofill/browser/wallet/wallet_items.cc
+++ b/components/autofill/browser/wallet/wallet_items.cc
@@ -6,8 +6,10 @@
#include "base/logging.h"
#include "base/string_number_conversions.h"
+#include "base/utf_string_conversions.h"
#include "base/values.h"
#include "components/autofill/browser/autofill_type.h"
+#include "components/autofill/browser/credit_card.h"
#include "googleurl/src/gurl.h"
#include "grit/generated_resources.h"
#include "grit/webkit_resources.h"
@@ -227,6 +229,19 @@ bool WalletItems::HasRequiredAction(RequiredAction action) const {
action) != required_actions_.end();
}
+const WalletItems::MaskedInstrument* WalletItems::GetInstrumentById(
+ const std::string& object_id) const {
+ if (object_id.empty())
+ return NULL;
+
+ for (size_t i = 0; i < instruments_.size(); ++i) {
+ if (instruments_[i]->object_id() == object_id)
+ return instruments_[i];
+ }
+
+ return NULL;
+}
+
string16 WalletItems::MaskedInstrument::DisplayName() const {
#if defined(OS_ANDROID)
// TODO(aruslan): improve this stub implementation.
@@ -245,6 +260,24 @@ string16 WalletItems::MaskedInstrument::DisplayNameDetail() const {
#endif
}
+string16 WalletItems::MaskedInstrument::TypeAndLastFourDigits() const {
+ string16 display_type = CreditCard::TypeForDisplay(kGenericCard);
Ilya Sherman 2013/03/27 23:59:23 Optional nit: Consider initing to an empty string,
Dan Beam 2013/03/28 03:38:12 well, don't we disagree, lol. anyways, Done.
+
+ if (type_ == AMEX)
+ display_type = CreditCard::TypeForDisplay(kAmericanExpressCard);
+ else if (type_ == DISCOVER)
+ display_type = CreditCard::TypeForDisplay(kDiscoverCard);
+ else if (type_ == MASTER_CARD)
+ display_type = CreditCard::TypeForDisplay(kMasterCard);
+ else if (type_ == SOLO)
+ display_type = CreditCard::TypeForDisplay(kSoloCard);
+ else if (type_ == VISA)
+ display_type = CreditCard::TypeForDisplay(kVisaCard);
+
+ // TODO(dbeam): i18n.
+ return display_type + ASCIIToUTF16(" - ") + last_four_digits();
+}
+
const gfx::Image& WalletItems::MaskedInstrument::CardIcon() const {
int idr = 0;
switch (type_) {

Powered by Google App Engine
This is Rietveld 408576698