Implementing VERIFY_CVV required action.

chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index 8f3896917bf10ee866f383523c2622d5ab36a918..5be411a2cdcae8b189aaa5aac0657832e97f7064 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -170,17 +170,20 @@ void GetBillingInfoFromOutputs(const DetailOutputMap& output,
 
     // Special case CVC as CreditCard just swallows it.
     if (it->first->type == CREDIT_CARD_VERIFICATION_CODE) {
-      cvc->assign(trimmed);
+      if (cvc)
+        cvc->assign(trimmed);
     } else {
       // Copy the credit card name to |profile| in addition to |card| as
       // wallet::Instrument requires a recipient name for its billing address.
-      if (it->first->type == CREDIT_CARD_NAME)
+      if (profile && it->first->type == CREDIT_CARD_NAME)
         profile->SetRawInfo(NAME_FULL, trimmed);
 
-      if (IsCreditCardType(it->first->type))
-        card->SetRawInfo(it->first->type, trimmed);
-      else
+      if (IsCreditCardType(it->first->type)) {
+        if (card)
+          card->SetRawInfo(it->first->type, trimmed);
+      } else if (profile) {
         profile->SetRawInfo(it->first->type, trimmed);
+      }
     }
   }
 }
@@ -427,7 +430,8 @@ string16 AutofillDialogControllerImpl::CancelButtonText() const {
 }
 
 string16 AutofillDialogControllerImpl::ConfirmButtonText() const {
-  return l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_SUBMIT_BUTTON);
+  return l10n_util::GetStringUTF16(IsSubmitPausedOn(wallet::VERIFY_CVV) ?
+      IDS_AUTOFILL_DIALOG_VERIFY_BUTTON : IDS_AUTOFILL_DIALOG_SUBMIT_BUTTON);
 }
 
 string16 AutofillDialogControllerImpl::CancelSignInText() const {
@@ -489,15 +493,20 @@ bool AutofillDialogControllerImpl::HadAutocheckoutError() const {
 bool AutofillDialogControllerImpl::IsDialogButtonEnabled(
     ui::DialogButton button) const {
   if (button == ui::DIALOG_BUTTON_OK)
-    return !did_submit_;
+    return !did_submit_ || IsSubmitPausedOn(wallet::VERIFY_CVV);
+
   DCHECK_EQ(ui::DIALOG_BUTTON_CANCEL, button);
   // TODO(ahutter): Make it possible for the user to cancel out of the dialog
   // while Autocheckout is in progress.
-  return had_autocheckout_error_ || !did_submit_;
+  return had_autocheckout_error_ ||
+         dialog_type_ == DIALOG_TYPE_REQUEST_AUTOCOMPLETE;
 }
 
 bool AutofillDialogControllerImpl::SectionIsActive(DialogSection section)
     const {
+  if (IsSubmitPausedOn(wallet::VERIFY_CVV))
+    return section == SECTION_CC_BILLING;
+
   if (IsPayingWithWallet())
     return section != SECTION_BILLING && section != SECTION_CC;
 
@@ -510,6 +519,11 @@ bool AutofillDialogControllerImpl::HasCompleteWallet() const {
          !wallet_items_->addresses().empty();
 }
 
+bool AutofillDialogControllerImpl::IsSubmitPausedOn(
+    wallet::RequiredAction required_action) const {
+  return full_wallet_ && full_wallet_->HasRequiredAction(required_action);
+}
+
 const DetailInputs& AutofillDialogControllerImpl::RequestedFieldsForSection(
     DialogSection section) const {
   switch (section) {
@@ -593,6 +607,10 @@ string16 AutofillDialogControllerImpl::LabelForSection(DialogSection section)
 
 string16 AutofillDialogControllerImpl::SuggestionTextForSection(
     DialogSection section) {
+  string16 action_text = RequiredActionSuggestionTextForSection(section);
+  if (!action_text.empty())
+    return action_text;
+
   // When the user has clicked 'edit', don't show a suggestion (even though
   // there is a profile selected in the model).
   if (section_editing_state_[section])
@@ -610,9 +628,28 @@ string16 AutofillDialogControllerImpl::SuggestionTextForSection(
   return wrapper->GetDisplayText();
 }
 
+string16 AutofillDialogControllerImpl::RequiredActionSuggestionTextForSection(
+    DialogSection section) {
+  if (section == SECTION_CC_BILLING && IsSubmitPausedOn(wallet::VERIFY_CVV)) {
+    const wallet::WalletItems::MaskedInstrument* current_instrument =
+        wallet_items_->GetInstrumentById(active_instrument_id_);
+    if (current_instrument)
+      return current_instrument->TypeAndLastFourDigits();
+
+    DetailOutputMap output;
+    view_->GetUserInput(section, &output);
+    CreditCard card;
+    GetBillingInfoFromOutputs(output, &card, NULL, NULL);
+    return card.TypeAndLastFourDigits();
+  }
+
+  return string16();
+}
+
 scoped_ptr<DataModelWrapper> AutofillDialogControllerImpl::CreateWrapper(
     DialogSection section) {
-  if (IsPayingWithWallet() && full_wallet_) {
+  if (IsPayingWithWallet() && full_wallet_ &&
+      !IsSubmitPausedOn(wallet::VERIFY_CVV)) {
     if (section == SECTION_CC_BILLING) {
       return scoped_ptr<DataModelWrapper>(
           new FullWalletBillingWrapper(full_wallet_.get()));
@@ -958,6 +995,14 @@ std::vector<DialogNotification>
                 UTF8ToUTF16(source_url_.host()))));
   }
 
+  if (IsSubmitPausedOn(wallet::VERIFY_CVV)) {
+    notifications.push_back(
+        DialogNotification(
+            DialogNotification::REQUIRED_ACTION,
+            l10n_util::GetStringUTF16(
+                IDS_AUTOFILL_DIALOG_VERIFY_CVV)));
+  }
+
   if (had_autocheckout_error_) {
     notifications.push_back(
         DialogNotification(
@@ -1008,8 +1053,7 @@ void AutofillDialogControllerImpl::OnCancel() {
   }
 }
 
-void AutofillDialogControllerImpl::OnSubmit() {
-  did_submit_ = true;
+void AutofillDialogControllerImpl::OnAccept() {
   metric_logger_.LogDialogUiDuration(
       base::Time::Now() - dialog_shown_timestamp_,
       dialog_type_,
@@ -1021,13 +1065,23 @@ void AutofillDialogControllerImpl::OnSubmit() {
     GetManager()->RemoveObserver(this);
     autocheckout_is_running_ = true;
     autocheckout_started_timestamp_ = base::Time::Now();
-    view_->UpdateButtonStrip();
   }
 
-  if (IsPayingWithWallet())
+  // Update the button strip after autocheckout may have started.

[ahutter, 2013/03/26 15:27:09]

nit: Autocheckout

[Dan Beam, 2013/03/26 18:03:14]

Done.

+  did_submit_ = true;
+  view_->UpdateButtonStrip();
+
+  if (IsSubmitPausedOn(wallet::VERIFY_CVV)) {
+    DCHECK(!active_instrument_id_.empty());
+    GetWalletClient()->AuthenticateInstrument(
+        active_instrument_id_,
+        UTF16ToUTF8(view_->GetCvc()),
+        wallet_items_->obfuscated_gaia_id());
+  } else if (IsPayingWithWallet()) {
     SubmitWithWallet();
-  else
+  } else {
     FinishSubmit();
+  }
 }
 
 Profile* AutofillDialogControllerImpl::profile() {
@@ -1145,19 +1199,24 @@ void AutofillDialogControllerImpl::OnDidAuthenticateInstrument(bool success) {
 
 void AutofillDialogControllerImpl::OnDidGetFullWallet(
     scoped_ptr<wallet::FullWallet> full_wallet) {
-  // TODO(dbeam): handle more required actions.
   full_wallet_ = full_wallet.Pass();
 
-  if (full_wallet_->HasRequiredAction(wallet::VERIFY_CVV))
-    DisableWallet();
-  else
+  if (full_wallet_->required_actions().empty()) {
     FinishSubmit();
+    return;
+  }
+
+  GenerateSuggestionsModels();
+  view_->ModelChanged();
+  view_->UpdateNotificationArea();
+  view_->UpdateButtonStrip();
 }
 
 void AutofillDialogControllerImpl::OnDidGetWalletItems(
     scoped_ptr<wallet::WalletItems> wallet_items) {
   // TODO(dbeam): verify all items support kCartCurrency?
   wallet_items_ = wallet_items.Pass();
+
   GenerateSuggestionsModels();
   view_->ModelChanged();
   view_->UpdateAccountChooser();
@@ -1298,6 +1357,7 @@ void AutofillDialogControllerImpl::DisableWallet() {
   account_chooser_model_.SetHadWalletError();
   GetWalletClient()->CancelPendingRequests();
   wallet_items_.reset();
+  full_wallet_.reset();
 
   GenerateSuggestionsModels();
   if (view_) {
@@ -1319,7 +1379,7 @@ void AutofillDialogControllerImpl::GenerateSuggestionsModels() {
   suggested_shipping_.Reset();
 
   if (IsPayingWithWallet()) {
-    if (wallet_items_.get()) {
+    if (wallet_items_) {
       // TODO(estade): seems we need to hardcode the email address.
 
       const std::vector<wallet::Address*>& addresses =
@@ -1332,21 +1392,25 @@ void AutofillDialogControllerImpl::GenerateSuggestionsModels() {
             addresses[i]->DisplayNameDetail());
       }
 
-      const std::vector<wallet::WalletItems::MaskedInstrument*>& instruments =
-          wallet_items_->instruments();
-      for (size_t i = 0; i < instruments.size(); ++i) {
-        // TODO(dbeam): respect wallet_items_->default_address_id().
-        suggested_cc_billing_.AddKeyedItemWithSublabelAndIcon(
-            base::IntToString(i),
-            instruments[i]->DisplayName(),
-            instruments[i]->DisplayNameDetail(),
-            instruments[i]->CardIcon());
+      if (!IsSubmitPausedOn(wallet::VERIFY_CVV)) {
+        const std::vector<wallet::WalletItems::MaskedInstrument*>& instruments =
+            wallet_items_->instruments();
+        for (size_t i = 0; i < instruments.size(); ++i) {
+          // TODO(dbeam): respect wallet_items_->default_address_id().
+          suggested_cc_billing_.AddKeyedItemWithSublabelAndIcon(
+              base::IntToString(i),
+              instruments[i]->DisplayName(),
+              instruments[i]->DisplayNameDetail(),
+              instruments[i]->CardIcon());
+        }
       }
     }
 
-    suggested_cc_billing_.AddKeyedItem(
-        std::string(),
-        l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_ADD_BILLING_DETAILS));
+    if (!IsSubmitPausedOn(wallet::VERIFY_CVV)) {
+      suggested_cc_billing_.AddKeyedItem(
+          std::string(),
+          l10n_util::GetStringUTF16(IDS_AUTOFILL_DIALOG_ADD_BILLING_DETAILS));
+    }
   } else {
     PersonalDataManager* manager = GetManager();
     const std::vector<CreditCard*>& cards = manager->credit_cards();
@@ -1704,6 +1768,7 @@ void AutofillDialogControllerImpl::FinishSubmit() {
   FillOutputForSection(SECTION_CC);
   FillOutputForSection(SECTION_BILLING);
   FillOutputForSection(SECTION_CC_BILLING);
+
   if (ShouldUseBillingForShipping()) {
     FillOutputForSectionWithComparator(
         SECTION_BILLING,
@@ -1714,6 +1779,7 @@ void AutofillDialogControllerImpl::FinishSubmit() {
   } else {
     FillOutputForSection(SECTION_SHIPPING);
   }
+
   callback_.Run(&form_structure_);
   callback_ = base::Callback<void(const FormStructure*)>();