Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: chrome/browser/android/chrome_jni_registrar.cc

Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Readd missing files Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/chrome_jni_registrar.cc
diff --git a/chrome/browser/android/chrome_jni_registrar.cc b/chrome/browser/android/chrome_jni_registrar.cc
index 859f651cce04eb179d243c5d388cd0890bfee6a2..54c80d8babef53f2ff7d18bf67589fe8fbe569b8 100644
--- a/chrome/browser/android/chrome_jni_registrar.cc
+++ b/chrome/browser/android/chrome_jni_registrar.cc
@@ -77,6 +77,7 @@
#include "chrome/browser/android/voice_search_tab_helper.h"
#include "chrome/browser/android/warmup_manager.h"
#include "chrome/browser/android/web_contents_factory.h"
+#include "chrome/browser/android/webapps/add_to_homescreen_helper.h"
#include "chrome/browser/autofill/android/personal_data_manager_android.h"
#include "chrome/browser/dom_distiller/dom_distiller_service_factory_android.h"
#include "chrome/browser/dom_distiller/tab_utils_android.h"
@@ -170,6 +171,8 @@ static base::android::RegistrationMethod kChromeRegisteredMethods[] = {
{"AccessibilityUtils", AccessibilityUtil::Register},
{"AccountChooserInfoBar", RegisterAccountChooserInfoBar},
{"AccountManagementScreenHelper", AccountManagementScreenHelper::Register},
+ {"AddToHomescreenDialogHelper",
+ AddToHomescreenDialogHelper::RegisterAddToHomescreenDialogHelper},
{"AfterStartupTaskUtils", RegisterAfterStartupTaskUtilsJNI},
{"AnswersImageBridge", RegisterAnswersImageBridge},
{"AppBannerInfoBarAndroid", RegisterAppBannerInfoBarAndroid},
@@ -247,7 +250,8 @@ static base::android::RegistrationMethod kChromeRegisteredMethods[] = {
{"InfoBarContainer", RegisterInfoBarContainer},
{"InvalidationServiceFactory",
invalidation::InvalidationServiceFactoryAndroid::Register},
- {"ShortcutHelper", ShortcutHelper::RegisterShortcutHelper},
+ {"ShortcutHelper",
+ ShortcutHelper::RegisterShortcutHelper},
gone 2015/08/19 18:49:16 any reason why this moved down? it fits on the li
Lalit Maganti 2015/08/20 17:12:18 Sorry this was a regression. I fixed this at some
{"IntentHelper", RegisterIntentHelper},
{"JavaExceptionReporter", RegisterJavaExceptionReporterJni},
{"JavascriptAppModalDialog",

Powered by Google App Engine
This is Rietveld 408576698