chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java - Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java

Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test file name Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialogHelper.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/ShortcutHelperTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java

index c360e056af0ae3d0a38c6dbf85b58a0bd099a38c..a69de0ced698dbc9381e91b01a6597390bf552bd 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java

@@ -12,7 +12,6 @@ import android.util.Base64;

import org.chromium.base.ApiCompatibilityUtils;

import org.chromium.base.Log;

-import org.chromium.chrome.browser.BookmarkUtils;

import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.ShortcutSource;

import org.chromium.chrome.browser.WebappAuthenticator;

@@ -77,7 +76,7 @@ public class WebappLauncherActivity extends Activity {

// launch the URL with a VIEW Intent in the regular browser.

launchIntent = new Intent(Intent.ACTION_VIEW, Uri.parse(webappUrl));

launchIntent.setClassName(getPackageName(), ChromeLauncherActivity.class.getName());

- launchIntent.putExtra(BookmarkUtils.REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB, true);

+ launchIntent.putExtra(ShortcutHelper.REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB, true);

launchIntent.putExtra(ShortcutHelper.EXTRA_SOURCE, webappSource);

}