chrome/android/java/src/org/chromium/chrome/browser/document/DocumentUma.java - Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentUma.java

Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test file name Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/AddToHomescreenDialog.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentUma.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentUma.java b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentUma.java

index 8f83a68d01748c346843fd6ce50cbaf6021ebca2..666e504af47a6f222199ef6e18ceb2c84837fecf 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentUma.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentUma.java

@@ -7,8 +7,8 @@ package org.chromium.chrome.browser.document;

import android.content.Intent;

import org.chromium.base.metrics.RecordHistogram;

-import org.chromium.chrome.browser.BookmarkUtils;

import org.chromium.chrome.browser.IntentHandler;

+import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.util.IntentUtils;

/**

@@ -46,7 +46,7 @@ public class DocumentUma {

intentSource = IntentUtils.safeGetIntExtra(intent,

IntentHandler.EXTRA_STARTED_BY, DocumentMetricIds.STARTED_BY_UNKNOWN);

} else if (IntentUtils.safeGetBooleanExtra(intent,

- BookmarkUtils.REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB, false)) {

+ ShortcutHelper.REUSE_URL_MATCHING_TAB_ELSE_NEW_TAB, false)) {

// TODO(dfalcantara): Add a new a boolean instead of piggybacking on this Intent extra.

intentSource = DocumentMetricIds.STARTED_BY_LAUNCHER;

} else if (IntentUtils.safeGetBooleanExtra(