Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 12888005: gpu: Add traces to Produce/Consume texture. (Closed)

Created:
7 years, 9 months ago by epenner
Modified:
7 years, 9 months ago
Reviewers:
gman1, greggman, no sievers
CC:
chromium-reviews, apatrick_chromium, alexst (slow to review), piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

gpu: Add traces to Produce/Consume texture. Currently consume is expensive. Also, we currently have no other way of detecting compositor frames being produced/consumed in the GPU process. BUG=220561 NOTRY=true No try since the aura failure isn't related. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189962

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Add more info. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
epenner
Ptal.
7 years, 9 months ago (2013-03-20 02:44:30 UTC) #1
greggman
lgtm
7 years, 9 months ago (2013-03-20 04:58:58 UTC) #2
no sievers
It would be super awesome if you could add two arguments to the trace events ...
7 years, 9 months ago (2013-03-20 18:20:10 UTC) #3
epenner
The first was easy. The second I just used the first byte as that seems ...
7 years, 9 months ago (2013-03-20 19:39:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/12888005/5002
7 years, 9 months ago (2013-03-20 19:54:14 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=21778
7 years, 9 months ago (2013-03-21 03:22:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/epenner@chromium.org/12888005/5002
7 years, 9 months ago (2013-03-23 00:08:16 UTC) #7
commit-bot: I haz the power
7 years, 9 months ago (2013-03-23 00:58:04 UTC) #8
Message was sent while issue was closed.
Change committed as 189962

Powered by Google App Engine
This is Rietveld 408576698